Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Allure results directory when using RESTestRunner #274

Merged

Conversation

mimbrero
Copy link
Member

RESTestLoader#createAllureReportManager() changes the default Allure results directory to a dedicated subdirectory for the experiment. However, RESTestRunner does not use that method, leading to inconsistent behavior and a directory with mixed results when running multiple experiments.

Solving this by overriding the allure.results.directory system property before running the tests.

@josgarmar31
Copy link
Collaborator

Hi @mimbrero,

Thank you for your pull request! We appreciate the time and effort you put into making these changes.

We've reviewed your code, and everything looks good. The changes align well with our project guidelines and improve the functionality as intended. Your contribution will be merged into the main branch shortly.

If you have any additional enhancements or suggestions in the future, please feel free to contribute again. We highly value your input and look forward to collaborating with you more.

Thanks again for your support!

@josgarmar31 josgarmar31 merged commit 487cdb0 into isa-group:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants