do not create empty patterns via ..

isaacs · Feb 13, 2023 · d67fa3f · d67fa3f
1 parent a26fe30
commit d67fa3f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -397,8 +397,8 @@ export class Minimatch {
           }
         } while (swapped)
       }
-      this.globParts = rawGlobParts.map(parts =>
-        parts.reduce((set: string[], part) => {
+      this.globParts = rawGlobParts.map(parts => {
+        parts = parts.reduce((set: string[], part) => {
           const prev = set[set.length - 1]
           if (part === '**' && prev === '**') {
             return set
@@ -412,7 +412,8 @@ export class Minimatch {
           set.push(part)
           return set
         }, [])
-      )
+        return parts.length === 0 ? [''] : parts
+      })
     }
 
     this.debug(this.pattern, this.globParts)

diff --git a/test/basic.js b/test/basic.js
@@ -221,3 +221,9 @@ t.test('globstar re matches zero or more path portions', t => {
   }
   t.end()
 })
+
+t.test('do not create empty pattern via ..', t =>{
+  const m = new mm.Minimatch('*/..')
+  t.same(m.globParts, [['']])
+  t.end()
+})