Skip to content

Commit

Permalink
allow symbol as an event type
Browse files Browse the repository at this point in the history
This was hiding because I have 'skipLibCheck' in most of my packages,
since it makes TS builds so much faster, and it's typically not a
problem, since libs get checked in their own development anyway.  But in
the case of something like Minipass, where it's not *actually*
typescript, but just JavaScript with a hand-written .d.ts, things can go
unnoticed.

Still an open todo to migrate minipass to a TS hybrid build, but in the
meantime, this fixes the problem for node-glob.

Fix: isaacs/node-glob#529
Fix: #49
Close: #50
  • Loading branch information
isaacs committed May 17, 2023
1 parent 6125cee commit 0c7b958
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export namespace Minipass {
: ObjectModeOptions

interface EventArguments {
[k: string]: unknown[]
[k: string | symbol]: unknown[]
}
/**
* The listing of events that a Minipass class can emit.
Expand Down

0 comments on commit 0c7b958

Please sign in to comment.