Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore documentation unclear, are the methods named ignore/ignoreChildren or ignored/childrenIgnored? #607

Closed
jedwards1211 opened this issue Sep 1, 2024 · 0 comments · Fixed by #608
Closed

Ignore documentation unclear, are the methods named ignore/ignoreChildren or ignored/childrenIgnored? #607

jedwards1211 opened this issue Sep 1, 2024 · 0 comments · Fixed by #608

Comments

@jedwards1211
Copy link
Contributor

ignore string or string[], or an object with ignore and ignoreChildren methods.

...

If an object is provided that has ignored(path) and/or childrenIgnored(path) methods, then these methods will be called to determine whether any Path is a match or if its children should be traversed, respectively.
jedwards1211 added a commit to jedwards1211/node-glob that referenced this issue Sep 1, 2024
@jedwards1211
docs: correct ignore method names
cd4c1db 
fix isaacs#607
@jedwards1211 jedwards1211 mentioned this issue Sep 1, 2024
Merged
@isaacs isaacs closed this as completed in 08958fa Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: correct ignore method names jedwards1211/node-glob
1 participant
@jedwards1211