Semver-major changes

.gitignore

@@ -1,3 +1,4 @@
 node_modules/
 coverage/
 .nyc_output/
+test/temp-files-*/

.travis.yml

@@ -5,11 +5,11 @@ node_js:
   - 12
   - 10
   - 8
-  - 6
 
 os:
-  - linux
   - windows
+  - osx
+  - linux
 
 cache:
   directories:

README.md

@@ -12,7 +12,6 @@ resilient to errors.
 * Queues up `open` and `readdir` calls, and retries them once
   something closes if there is an EMFILE error from too many file
   descriptors.
-* fixes `lchmod` for Node versions prior to 0.6.2.
 * implements `fs.lutimes` if possible. Otherwise it becomes a noop.
 * ignores `EINVAL` and `EPERM` errors in `chown`, `fchown` or
   `lchown` if the user isn't root.
@@ -79,8 +78,7 @@ also imposes the challenge of keeping in sync with the core module.
 
 The current approach loads the `fs` module, and then creates a
 lookalike object that has all the same methods, except a few that are
-patched.  It is safe to use in all versions of Node from 0.8 through
-7.0.
+patched.
 
 ### v4
 

check-for-callback.js

@@ -0,0 +1,42 @@
+'use strict'
+
+const nodeMajor = process.versions.node.split('.')[0]
+
+/* This function emulates the functionality of node.js 7, 8 and 9 by emitting a
+ * deprecation warning.  In node.js 10+ a TypeError is produced. */
+function checkForCallback (cb, ctor) {
+  if (typeof cb === 'function') {
+    return true
+  }
+
+  if (nodeMajor >= 10) {
+    /* It's possible that the caller provided something incorrect for the callback
+     * but more likely they omitted the argument.
+     *
+     * The error is technically wrong if someone provides something for the callback
+     * argument which is not a function, for example `fs.mkdir('/path', {}, 'cb')`
+     * should say that a string was provided.  Providing the correct exception for
+     * this off nominal case would require argument processing to be specific to each
+     * patched function. */
+    const error = new TypeError('Callback must be a function. Received undefined')
+    error.code = 'ERR_INVALID_CALLBACK'
+
+    /* The next 4 lines are copied from node.js, lib/internal/errors.js:addCodeToName() */
+    error.name = `${error.name} [${error.code}]`
+    Error.captureStackTrace(error, ctor)
+    error.stack // eslint-disable-line no-unused-expressions
+    delete error.name
+
+    throw error
+  }
+
+  process.emitWarning(
+    'Calling an asynchronous function without callback is deprecated.',
+    'DeprecationWarning',
+    'DEP0013',
+    ctor
+  )
+  return false
+}
+
+module.exports = checkForCallback

chown-er-filter.js

@@ -0,0 +1,28 @@
+'use strict'
+
+// ENOSYS means that the fs doesn't support the op. Just ignore
+// that, because it doesn't matter.
+//
+// if there's no getuid, or if getuid() is something other
+// than 0, and the error is EINVAL or EPERM, then just ignore
+// it.
+//
+// This specific case is a silent failure in cp, install, tar,
+// and most other unix tools that manage permissions.
+//
+// When running as root, or if other types of errors are
+// encountered, then it's strict.
+function chownErFilter (er) {
+  if (!er || er.code === 'ENOSYS') {
+    return
+  }
+
+  const nonroot = !process.getuid || process.getuid() !== 0
+  if (nonroot && (er.code === 'EINVAL' || er.code === 'EPERM')) {
+    return
+  }
+
+  return er
+}
+
+module.exports = chownErFilter

clone.js

@@ -3,17 +3,11 @@
 module.exports = clone
 
 function clone (obj) {
-  if (obj === null || typeof obj !== 'object')
-    return obj
+  const copy = Object.create(Object.getPrototypeOf(obj))
 
-  if (obj instanceof Object)
-    var copy = { __proto__: obj.__proto__ }
-  else
-    var copy = Object.create(null)
-
-  Object.getOwnPropertyNames(obj).forEach(function (key) {
+  for (const key of Object.getOwnPropertyNames(obj)) {
     Object.defineProperty(copy, key, Object.getOwnPropertyDescriptor(obj, key))
-  })
+  }
 
   return copy
 }