use mkdirp v1

isaacs · Jan 28, 2020 · eeb8649 · eeb8649
1 parent 2c9d359
commit eeb8649
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 14 deletions.
diff --git a/lib/mkdir.js b/lib/mkdir.js
@@ -76,7 +76,7 @@ const mkdir = module.exports = (dir, opt, cb) => {
     })
 
   if (preserve)
-    return mkdirp(dir, mode, done)
+    return mkdirp(dir, {mode}).then(made => done(null, made), done)
 
   const sub = path.relative(cwd, dir)
   const parts = sub.split(/\/|\\/)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -20,7 +20,7 @@
     "fs-minipass": "^2.0.0",
     "minipass": "^3.0.0",
     "minizlib": "^2.1.0",
-    "mkdirp": "^0.5.0",
+    "mkdirp": "^1.0.3",
     "yallist": "^4.0.0"
   },
   "devDependencies": {
@@ -35,7 +35,7 @@
   },
   "license": "ISC",
   "engines": {
-    "node": ">= 8"
+    "node": ">= 10"
   },
   "files": [
     "index.js",

diff --git a/test/unpack.js b/test/unpack.js
@@ -145,7 +145,7 @@ t.test('links!', t => {
   const stripData = fs.readFileSync(tars + '/links-strip.tar')
 
   t.plan(6)
-  t.beforeEach(cb => mkdirp(dir, cb))
+  t.beforeEach(cb => mkdirp(dir).then(() => cb(), cb))
   t.afterEach(cb => rimraf(dir, cb))
 
   const check = t => {
@@ -1722,7 +1722,7 @@ t.test('set owner', t => {
       unl()
     })
 
-    t.beforeEach(cb => mkdirp(dir, cb))
+    t.beforeEach(cb => mkdirp(dir).then(() => cb(), cb))
     t.afterEach(cb => rimraf(dir, cb))
 
     const check = t => {
@@ -1775,7 +1775,7 @@ t.test('unpack when dir is not writable', t => {
   ])
 
   const dir = path.resolve(unpackdir, 'nowrite-dir')
-  t.beforeEach(cb => mkdirp(dir, cb))
+  t.beforeEach(cb => mkdirp(dir).then(() => cb(), cb))
   t.afterEach(cb => rimraf(dir, cb))
 
   const check = t => {
@@ -1812,7 +1812,7 @@ t.test('transmute chars on windows', t => {
   ])
 
   const dir = path.resolve(unpackdir, 'winchars')
-  t.beforeEach(cb => mkdirp(dir, cb))
+  t.beforeEach(cb => mkdirp(dir).then(() => cb(), cb))
   t.afterEach(cb => rimraf(dir, cb))
 
   const hex = 'ef80bcef81bcef80beef80bfef80ba2e747874'