Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: address "write after end" bug #182

Closed
wants to merge 1 commit into from
Closed

bugfix: address "write after end" bug #182

wants to merge 1 commit into from

Conversation

stsvilik
Copy link

@stsvilik stsvilik force-pushed the fix-write-after-end branch from f0a6d24 to be9064b Compare May 18, 2018 20:05
@stsvilik
Copy link
Author

You may want to lint this repo - I found a bunch of unused variables

@stsvilik stsvilik mentioned this pull request May 18, 2018
Closed
8 tasks
@prabhu
Copy link

prabhu commented May 20, 2018

Any chance of fixing this defect?

@stsvilik
Copy link
Author

@prabhu The underlying defect is already addressed here isaacs/minipass@55ed167, however this PR is valid as well and further enhances reliability

@isaacs
Copy link
Owner

isaacs commented May 24, 2018

I'd rather not use .once() if the event can only be emitted once anyway.

The write after end issue was not actually related to multiple end events being emitted, but rather to pacote actually writing after end, because it was writing to a stream that was already being piped into.

@isaacs isaacs closed this May 24, 2018
@stsvilik
Copy link
Author

My thought was that using .once() would simply reinforce the rule in case some code attempts (mistakenly) invoke end second time. I agree that it might masque the real problem, but at least it wouldn't break (like it did).

JayCanuck added a commit to enactjs/enact-dev-dist that referenced this pull request May 31, 2018
@JayCanuck
Cherry-pick changes for node-tar from isaacs/node-tar#182 to handle "…
dbb73a4 
…write after end" bug.
@ghost
Copy link

ghost commented Jun 12, 2018

This bug is reproduced on mac os. It's really awkful

@stsvilik stsvilik mentioned this pull request Jun 13, 2018
Open
14 tasks
@shibinrajumathew
Copy link

shibinrajumathew commented Jun 18, 2018 •
edited
Loading

This bug is reproduced on ubuntu also

chbae pushed a commit to webosose/meta-webosose that referenced this pull request Sep 20, 2018
@JayCanuck
enact-framework=v2.0.1,r3 enact-dev-native=v1.0.10,r6
495a724 
:Release Notes:
Updated Enact devtools and Enact framework

:Detailed Notes:
* Updated build framework Enact to 2.0.1
* Update to latest Enact-CLI devtool 1.0.10 release.
* Update webos_enactjs_app.bbclass to attempt NPM install
  up to 5 attempts to add additionally redundancy.
* Transpiles babel-polyfill for target system
* Enact framework stores in tarball format
* webos_enact_app.bbclass now uses override script to use build Enact
  tarballs
* Use common NPM package cache directory for Enact apps to reduce
  amount of external calls needed.
* Verbose Enact CLI devtool and app bbclass logging
* Use '-o' option to deploy app to target location directly
  instead of 'cp' command. ('cp' caused unexpected error)
* Clear NPM cache for enact devtools during sysroot_stage_all.
* Update Enact Node to 8.11.3 and NPM to 5.10.0.

enact-dev 0.9.5..1.0.10:
de87ef7 ENYO-5478: Prerendering: can notice default font until locale
        class are added (1 QE)
fd21928 1.09 cherrypick release
2cef6d6 ENYO-5440: locale class isn't applied if app uses deeplink
        feature
25cff9d ENYO-5438: dynamic locale classes missing whitespace
        separator.
97ef4e1 ENYO-5358: fix snapshot build with react-dom 16.4.1, using
        deferred timer utilities.
da94f70 Fixes for Shrinkwrap override with NPM 5.1.0 and later.
65fbe18 1.0.8 release
c251453 Node 8.11.3 and NPM 5.10.0
4ba7633 1.0.7 release
fe70a9d ENYO-5310: Add vebose logging support to Enact CLI pack
3d7842c Remove thread loader usage.
f963727 Updated shrinkwrap override with NPM 3.x shrinkwrap
        compatibility.
4beb6be ENYO-5311: Disable calc optimization support in css-loader
        due to a bug where it's destroying css variable that include
        the word fragment "calc". Eg. --tooltip-calculated-offset.
        See postcss/postcss-calc#50
1f3255f Correct minipass bugfix to correctly match upstream changes
f8550c8 ENYO-5287: CLI not respecting global._babelPolyfill and not
        correctly transpiling babel-polyfill requests into targeted
        core-js polyfills.
4b07a66 Enact framework dependencies override script
b351bc3 Incorporate minipass change from
        isaacs/minipass@55ed167abda3f2efb0a-
        -b900b7e080675b101e083 to prevent multiple 'end' events.
dbb73a4 Cherry-pick changes for node-tar from
        isaacs/node-tar#182 to handle "write
        after end" bug.
149e3b8 1.0.5 release
193c628 Support dynamic enact resolution class usage in prerendered
        html output.
0e7ad99 1.0.4 release details.
dd71205 ENYO-5208: Preserve React15 HTML comment nodes within prerenders
5a4163e PLAT-53067: Move dependencies to React 16.3
0deb7ec Always use entry-based polyfill support
dbcae90 Commiting package-lock.json
9a5a424 1.0.3 release information.
9428773 Don't include dev transforms in standalone ES5 transpiles.
c8aab70 ENYO-5142: Support v8-compile-cache for faster CLI runtime
12006a2 ENYO-5148: Add global flag to disable in-bundle babel-polyfill
        loading. Used during prerendering to avoid memory leaks.
64d6ef2 Support template name normalization, removing 'enact-template-'
        and 'template-' prefixes for auto-naming.
05844b9 Updates for 1.0.2 release.
7c8abcc Specifically display Travis badge reflecting master branch.
224ff94 Updated version and changelog for 1.0.1. Updated
        `@enact/dev-utils` fixing React 16 issues with v8 snapshot
        support.
0c2235d Fix automatic name detection for NPM packages when using
        version/tag specifiers
7bdf9a0 Temporary `--framework` alias for `--strict` while dependant
        systems update.
c3e7b2e Docs link fix
576c4e4 Support 'install' generator property, fix event hooks as
        optional, and only use default value on undefined.
5911871 Updated docs for 1.0.0 features/functionality.
6e40fca Spacing fix in help output.
71cfec6 Updated changelog for 1.0.0.
d0ae8f1 Updated dependencies.
55a54a5 Updates to for removal of unneeded test-json command and
        re-targeted template dependencies.
7f430e7 Support @enact/dev-utils 1.0.0
ce09ca8 PLAT-37902: Fix windows-specific ilib issues with testing
53a458d PLAT-51329: Update badges to common styling with enact
        (flat-square style)
91df013 Include ajv@^6.0.0 to workaround an NPM 5.6.0 bug with
        peerDependency hoisting (see
        angular/angular-cli#9691)
87d392f Support --fix option to forward to eslint.
6353abd Fix edge-case of no browsers and no node resulting in false
        rather than an empty object.
bb647ac ENYO-5009: Upgrade to Babel 7 and update dependencies.
956b29a Workaround for UTF8 output on Windows PowerShell ISE by
        specifically outputting a BOM.
918af04 ENYO-5000: Support Prettier styling format
afc8e24 ENYO-5008: Implement template management support
d2da563 Fix npm url
2470d7b 0.9.8 release
2427508 Added badges and sinplified summary.
c9739a5 Restore usage of extract-text-webpack-plugin when serving with
        Webpack 3.6.0.
5155f83 PLAT-50403: Update references to old github repo
f3e319b Update enact-cli to react 16
f095311 Fix broken docs link
8e8a048 0.9.7 release
8912582 PLAT-48934: Update copyright notice
a4a822d Help information correction for root usage.
5639b1d Updated dependencies
a8727de Enact Docs title format fix
56fcbd8 0.9.6 release
04fc432 PLAT-40859 & PLAT-40262: Docs, licensing, and renaming updates.
433bc1a Use separate logic for ES5 forced transpilation to avoid
        setting "test" env var, which disables Babel dev-expression
        plugin. Ensure transpiled library forces ES5 as well.
08abc31 ENYO-4894: Use ES6-compatible minifier to allow for selective
        transpiling
eb41d79 Dependencies update and remove unused dependencies.
0feabd5 Use pre-built babel-polyfill distribution file and remove old
        polyfills.
26ecc08 Add missing babel-polyfill dependency
1db78c7 Use updated @enact/dev-utils release for targetted build support
53537aa PLAT-40726 & ENYO-4798: Support babel-preset-env with dynamic
        targetted babel-polyfill usage
843fe48 Bump @enact/dev-utils versions
b12ed89 PLAT-46490: Add dynamic enact app option parsing
3ea328a Disable error-overlay as it prevents easy debugging an expect
        create-react-app's babel config with node polyfills, which we
        haven't implemented yet. (reverted from commit
        871f3ab058beb13822675f4f168e80791e8bc9a7)
871f3ab Disable error-overlay as it prevents easy debugging an expect
        create-react-app's babel config with node polyfills, which we
        haven't implemented yet.
8c0c398 ENYO-4783: Restore upstream extract-text-webpack-plugin and
        update dependencies.
72bb8db PLAT-45654: Add support for Electron build type
482a236 ENYO-4048: Reorganize webpack plugins
7ba7c8b Use an external extract-text-webpack-plugin to avoid error on
        direct npm install of enact-dev repo
16be5f6 ENYO-4653: Abnormal behaviour with 'serve'.

enact 1.13.3..2.0.1:
c54c4cc3 Version value updating
dda8a172 ENYO-5515: Make story sizing rule selectors more specific
4c3542fc Update change log for 2.0.1
6a429f2d ENYO-5519: Fix blurring component when pointer leaves window
         on webOS
29f983e7 ENYO-5493: Fix Dialog read order
b10f833b Go to next page properly via page up/down keys
7aa313bb PLAT-61280: Review UI docs
60b430e9 Update contributing and PR template
f123bec4 Version value updating
6a0d0b95 ENYO-5505: Fix QA sampler for Button tap area
53cfe114 remove deprecation warning for tooltip props on Button
ed916718 Update CHANGELOG
7d0840d0 PLAT-62487: Added LabeledIcon and LabeledIconButton
2fafbd40 Version value updating
fe2702f1 Update change logs for 1.13.4
d7afa012 ENYO-5434: Add prop for auto showing media controls in
         VideoPlayer
85f65c47 ENYO-5494: Fix minYear and maxYear in DatePicker for
         non-Gregorian locales
766cfb7f ENYO-5506: Fix scrolling by voice control in RTL locales
def0f042 PLAT-62487: Add inline support to kinds
58d95f3b PLAT-63668: Revise Scrollable-related patches
1347cec6 PLAT-62487: Update ui/Skinnable to use new context API
6a477983 Update extends and mixins docs
b811100c ENYO-5489: Fix Scrollable to ignore native drag events
7826bd32 add forceDirection knob to Marquee
6a2d77c4 ENYO-5482: Fix restricting spotlight to Popup when open on
         mount
8fb0a8bc ENYO-5481: Fix spotlight to blur when pointer leaves floating
         webOS app
de88bc8f ENYO-5355: Show Title/TitleBelow only when title is available.
8be8a3a3 PLAT-61708: Update Moonstone docs for EditableIntegerPicker to
         MoonstoneDecorator
f622ef06 ENYO-5145: Set 5-way mode when initializing.
935a972b ENYO-5455: Fix more button audio guidance in VideoPlayer
0abb44d7 ENYO-5419: Sync page up/down navigation spec between
         VirtualList and Scroller
c0939a41 PLAT-62228: Set a 5way key mode when pressing a key to focus
         an item
99f942c9 ENYO-5431 Sampler: VideoPlayer: Selecting 'noAutoPlay' knob
         causes console 'Uncontrolled input' Warning
7cc631af Changed overscroll color more recognizable on the focused
         element
db5cdde2 Version value updating
23e2f048 Update CHANGELOGs
0c9ed640 Update CHANGELOGs
596416be PLAT-62472: Update migration guide to reflect changes made
         since last updates
ea2302ad PLAT-62358: Updated the RadioItem stroke to ~"2px"
ceee56ff PLAT-61832: Fix time calculation over DST boundary in fa-IR
64d99e4c PLAT-61279 Review Moonstone docs (N-Z)
8f1c6160 ENYO-5304: Fix ContextualPopup to refocus activator on close
         for a11y
24404801 ENYO-5442: Defer to reset Scrollable restore flag
5dc61725 ENYO-5449: Fix Slider to prevent 5-way actions when activated
990a69be ENYO-5454: Fix closeOnSelect spotlight action
5100ecd3 ENYO-5459: Disable lockfile generation for packages
a2380536 ENYO-5348: Add issue templates
d9620351 ENYO-5457: Spotlight: focus disappears when spinner is
         unmounted
2b5a7d5f ENYO-5166: Match Dialog's padding to Popup's
763d0439 ENYO-5377: Fix Popup to set open correctly while transitioning
2ecaaf12 PLAT-62418: Fixed to scroll properly when holding down paging
         control buttons
3e8b11db ENYO-5367: Fix spotlight pause in ExpandableItem with no
         children
ca520f13 Version value updating
81152809 Update change logs for 2.0.0-rc.2
e6f856d3 ENYO-5432: Fix restoring focus in moonstone/VirtualList
9869dfaf ENYO-5356: Fix Feedback tooltip showing condition
a0928aac Prevent tab to input
2d55cc33 ENYO-5405: Fix Picker 5-way focus behavior
a40ee2ef PLAT-62474: Add guard for disabling Scrollable container
         during flick event
2c3f8cf4 PLAT-58297: Add voice control to Pickers
cc9248ae ENYO-5365: Fixed overscroll effects on improper timing
3ab4e7bb PLAT-58640: Fix VirtualList focus when entering 5way mode
1a679549 ENYO-5424: VirtualListNative: scroll animation occurs when
         calling scrollTo with animate false (1 QE)
c036882e ENYO-5415: Fix to call stopPropagation() properly
da03ab28 ENYO-5414: ProgressBarTooltip: warning is displayed in console
         for `rtl` prop
3ed55bb9 PLAT-62334:  Add data-spotlight-container-disabled knob in
         Scroller qa-sampler
2ee87d64 PLAT-62141: Add spotlight 5-way debugging
ed66af58 Version value updating
ebb7b056 Fix Spotlight.getCurrent() to be prerender-safe
806671a4 storybook knob fixes
18b4370b PLAT-60136: Remove TooltipDecorator Support From Button
df89b3a3 Update CHANGELOG
806dcb94 PLAT-62371: Fix assigning voice props to correct node in
         VirtualList
6646c0b6 delete prop
db9f6496 Fix Spinner to check existence of focused element before
         blurring
a762ae19 PLAT-29367: Create an Enact Glossary
adb9cff9 PLAT-62142: Remove public APIs using deprecated context API
69903c84 ENYO-5393 - Added spotlight blur when spinner is launched
0ce97197 PLAT-61631 - Added Docs for Interoperability
d625a8cc PLAT-62171: Support voice control to joined picker
868d3550 ENYO-5399: Workaround for proper Chromium feature detection on
         webOS
d80b1034 PLAT-62147: Limit voice control area of ContexturePopup
a180b0b3 PLAT-61241: Handle direction keys properly over ScrollButtons
         when `focusableScrollbar` is false
2f998c06 PLAT-61242: VirtualList/Scroller: Handle a page up or down key
         in pointer mode
cccfeb95 ENYO- 5398: Fix more button color default value
12a57468 PLAT-61278: Update Moonstone docs for BodyText through Divider
be2328d9 ENYO-5397: Fix sampler knob to return empty string for null
08d4b892 Version value updating
3589fcbf Update CHANGELOG
e5911eed ENYO-5396: Fix TooltipDecorator to remain visible when window
         is clicked
8c3237fa Clarify popup and spinner docs
c245eaba Clarify doc standards
7dd0f893 ENYO-5338: Add positionContextualPopup method
069e7671 PLAT-61006: Update QA sampler knobs
08e52d9d ENYO-5387: Add disableFullscreen config to MoonstoneDecorator
29f143d2 ENYO-5162: Fix Divider to always use a fixed height
07855dbd PLAT-61276: Update core docs
325878c8 ENYO-5339: Fix Scrollable to scroll properly after Scroller
         changes
666b4296 ENYO-5378: Fix TooltipDecorator to prevent unnecessary renders
a2cceef4 PLAT-61706: Add moreButtonColor knob to VideoPlauyer sample
20b23eeb Version value updating
baf2d040 Fix missing memberof tag in i18n/util
9b745f77 Fix missing link in docs for icons
64bf7aea Update CHANGELOG
82978bd9 PLAT-42418: Update docs for node-component proptypes
3daae74f ENYO-5103: Link doesn't work in
         http://enactjs.com/docs/tutorials/setup/
bd3b926d ENYO-4992: Update webos module docs
bc1d3e9c ENYO-5359: Fix ProgressBar prop type warning
747d6271 PLAT-57992: Add support for scrolling via voice control
63cdfb87 ENYO-5362: Fix sampler knobs for VideoPlayer and MediaOverlay
b88d6957 PLAT-61027 - Add Performance Docs
f12a368d Feature/plat 61283
b3d7fcd7 PLAT-61277: Update i18n docs
5f2218c5 PLAT-54713: Fix marquee behavier of mediaOverlay
2b9ee5bf PLAT-61063: Delegate voice group label to IconButton
afcf2d03 PLAT-61174: Add default declaration of voice intent
b0111687 PLAT-61178: Change intent name of toggle item
27fda70b ENYO-5349: Reatin focus for disabled component after updates
229c6726 ENYO-5354: Fix Spottable emulation of onMouseUp events
3a1c43f9 ENYO-5352: Change Divider's marqueeOn default value to `render`
27095650 ENYO-5289: Enact migration guide is in the wrong place
407654b6 Fix typo
513a8a4d PLAT-49795: Add overscroll effect for moonstone
cd29721f PLAT-54239: Fix samples to show the correct component name in
         source view
2f546210 Update documentation guidelines
058a0a56 ENYO-5217: Fix Spottable data-preventscrollonfocus usage
a0407f6b ENYO-5351: Fix Video infinite state loop when only updating
         the primary source
45ebb420 PLAT-53458: ScrollButton to move a previous or next page when
         pressing a page up or down key
d132297d ENYO-5346: Fix VirtualList to allow scrolling on focus on webOS
9f5c63dd Updated Travis with cached NPM cache
a803eeeb Version value updating
6aec3a29 Update CHANGELOG for release
0f4474e4 ENYO-4947:  Ensure Picker disables when containing 1 or no
         items
044983d2 ENYO-5321: Fix VideoPlayer to show media controls when
         pressing down in pointer mode
379ec279 ENYO-5047: Add QA sample for ExpandableList with default
         selection
5821af38 PLAT-58649: Fix VideoPlayer to allow 5-way navigation out of
         media controls
df8c4b4b ENYO-5326: MarqueeDecorator handle pointer hide
a42149ec PLAT-54548: Disable VideoPlayer playback controls until it's
         playable
356ef224 PLAT-60545: Clean up deprecated properties in 2.0.0
7cb3e52e ENYO-5333: Popup spot content correctly on mount
7157dd59 ENYO-5268: Fix MediaControls to handle directional events when
         player has focus
4278401a Fix docs and comments to use "falsy"
6ef734fa ENYO-5329: Fix TooltipDecorator to hide tooltip on onDismiss
488ffbcc PLAT-60211: Fixed qa-sampler slider runtime error
40f7d301 ENYO-5324: Fix VideoPlayer controls 5-way behavior
7e2fd9d6 PLAT-60139: Create QA sample for testing Touchable: add
         support for emitting onTap for click events
6345ae9a Version value updating
6d30f23f Update change log for 2.0.0-beta.6
b094f3cb ENYO-5322: Fix floatingLayer unmount condition
d1077b6c ENYO-5322: Fix floatingLayer unmount condition
700ccd20 ENYO-5217: Fix Spottable to prevent scroll on focus on webOS
500972ce ENYO-5319: Fix ContextualPopupDecorator to allow focusing
         components under its popup
506949d6 ENYO-5029: Fix readAlert to subscribe to audio guidance changes
825a7727 Fix typo
c4999e4a ENYO-5320: Add bad image source for testing placeholder
93490008 PLAT-50075: Added introduction to component customization docs
e4dd2cd6 ENYO-5318: Fix small ToggleButton layout in RTL
66de922d ENYO-5151: Adjust Spotlight Partitions/Priorities
2df90f45 ENYO-4987: Set correct active Panel container id on render
c2100e93 ENYO-5293: Fix FloatingLayer to render if already opened at
         mounting time
e7802ed4 ENYO-5312: Remove unsupported children prop from
         IncrementSlider
9387130f ENYO-5315: Fix to show thumbnail only when focused on slider
3fffd277 ENYO-5314: Fix to not hide title and info when showing more
         components
185dd7b6 ENYO-5313: Fix seeking in 5-way mode
5a85cf3b ENYO-5282: Disable MediaSlider if the source is unavailable
f1fa63cf ENYO-5231: Fix scrolling by page down at Scroller bounds
2bde5eee ENYO-5234: Fix Scroller's logic for calculating focus scrollTop
f68c2d78 ENYO-5294: Add smartSelect knob utility to Storybook
188f3abe Update resolution workspaceBounds to window dimensions during
         ResolutionDecorator's constructor to fix snapshot sizing.
6b35e74b Version value updating
9a63c0fb ENYO-5299: Forward onDismiss only if defined
2ff37586 Updated CHANGELOGS
fc41e2c3 ENYO-5307: Change noAutoPlay to autoPlay in Video
d295807d ENYO-4825: Add closeAllFloatingLayer to FloatingLayerDecorator
e32a503f ENYO-5070: Fix MarqueeController to update hovered state when
         pointer hides
dea8675c PLAT-53612: Add ability to select a range of a MediaSlider
5ff8b0cd ENYO-5213: Remove "none" allowed value from spotlightRestrict
         prop of Popup
1392243e ENYO-5244: Add Video component for preload support
4fb59177 ENYO-5255: Add cancel support to MediaControls and VideoPlayer
bc837e7d ENYO-5153: Fix Button prop allowed values and sampler usage
93ea8b19 ENYO-5199: Fix ContextualPopupDecorator to properly stop
         keydown event propagation
9edd8fdd ENYO-5245: Fixed not focusing scroll buttons from items via
         5way
c3f971e4 ENYO-5276: ToggleButton padding fix
4fb4e4a0 PLAT-58152: Fix forwarding voice control props for Input and
         ExpandableItem
d6fd817e PLAT-58654: Fix readme file (enact/i18n)
0b140f3f ENYO-5237: Add slider role and fix incorrect proptypes in
         SliderBehaviorDecorator
d914d91a ENYO-5254: Fix VideoPlayer first play read out
c3c04e10 ENYO-5112: Touchable End Gestures when Blurred
0a92e008 ENYO-5110: Fix layout of Input and ContextualPopup QA samples
a645379b ENYO-4914: Fix Scroller bounds when an ExpandableItem is opens
8c848b76 Version value updating
d7600ec8 Updated CHANGELOGS
90a728df Update change logs for 2.0.0-beta.4
7ed8df8d ENYO-5280: Fix MarqueeController incorrectly canceling valid
         animations
0425a9b8 ENYO-5253: Fix Spottable to prevent making component spottable
         when disabled
9e6bfd12 ENYO-5271: Add debugging utilities to core/handle
58d5d171 PLAT-57884: Limit voice control area when popup is open
b59c2e78 ENYO-5273: Fix VideoPlayer to show MediaControls on mount
3c1824df Add links to GitHub
c9b0994f ENYO-5222: Update doc for disabled prop in Marquee
0cde2cec PLAT-52482: Added a `highlighted` prop to ProgressBar
fce6a9bc PLAT-58301: Fix Touchable runtime error from simulated
         onMouseUp from Spottable
c198e80e ENYO-5187: Fix VideoPlayer feedback timeouts
64827a7b ENYO-5230: Fix default spotlight focus to media controls
f9eb2ec6 ENYO-5200: Enact docs: prepare 1.x to 2.0 migration guide
60469e09 ENYO-5250: ContextualPopupDecorator to not steal focus on close
f6a7e936 add subTitleBelow to Header qa-sample
93c0685b PLAT-54708: Fixed `storybook` lists to show items properly
         when `dataSize` is greater than 1000.
85e9827a PLAT-57949: Add description to VoiceControlDecorator
c00b2959 ENYO-5143: Fix IconButton to allow adjustments to Icon
         vertical alignment
769684a6 PLAT-54691: Prevent Unnecessary Spottable and Marquee
         Focus-based Updates
c59b4a15 ENYO-5115: Fix to scroll properly with all enabled items via a
         page up or down key
e7c8a696 Version value updating
39fb83ca ENYO-5264: Fix Touchable to only send one tap on emulated
         mouse click
6f5515cc Updated CHANGELOGS
342b0ab2 PLAT-54096: Add unit test for DatePicker, ExpandablePicker,
         TimePicker, internal/Picker
0f46161e Handle data-spotlight-container-disabled property in Scrollable
7e2cb729 ENYO-5156: Change ToggleItem to forward native events for
         onFocus and onBlur
a280fa19 ENYO-5252: Add fallback focus attempt on window focus
4e732a8c PLAT-53609 - Touchable: add support for emitting onTap for
         click events
4575ca82 ENYO-5227: Updated the disabled color of items
63262fc2 ENYO-5243: Add valid Input props
a26b7f79 ENYO-5146: Fix spotlight handling when leaving ExpandableInput
a5df2d22 ENYO-4747: Fix spotlight handling 5-way events when in pointer
         mode
3c2b8b6b ENYO-5089: Check pointer mode before handling key events in
         Scrollable
2c527025 feature/changelog-update
edee290f ENYO-5213: Fix Popup spotlightRestrict handling
26cbaa40 ENYO-5221: Automatic Image src swapping during resolution
         change
d5de52d4 Version value updating
20c7facc ENYO-5143: IconButton is now visually customizable
b4e1bedb Update root CHANGELOG
96e35ee0 ENYO-5111: Update Group QA samples to apply disabled prop
57397ba2 ENYO-5210: Fix Marquee to always animate when
         marqueeOn="render"
8e813f3d ENYO-5154 Account for disabled items in ExpandableItem
89c703ff ENYO-5241: Prevent adding duplicate handlers with
         core/dispatcher
6f430679 ENYO-5195: Fix to not fire onChange event when 5-ways out of
         boundary
6ab69525 ENYO-5125: Fix moonstone/ToggleButton layout in RTL locales
055297d9 ENYO-5223: Remove duplicate classNames in moonstone/Item family
41df8592 ENYO-5019: Fix to correctly reset marquee animation when
         children updates
100cc2ce ENYO-5236: Fix vertical scroll bar button aria-label in RTL
a973b2ca ENYO-5236: Fix Scrollbar button's aria-lable in RTL
3fc23dcd ENYO-5231: Fix the wrong spotlight ID in Scrollable
7f5c014e ENYO-5228: Fix to scroll properly with all disabled items in
         VirtualList
62d1aa78 ENYO-5041: Check before blurring for self-only type contextual
         popup
01b90845 ENYO-5039:  Add flag to ignore to scroll on focus when jumping
d6682371 ENYO-5212: Fix Spottable setting its focused state when
         disabled
58b0cd74 ENYO-5220: Fix moonstone/Item width when inline
2e8881f2 Version value updating
bce72368 Update CHANGELOG
e0408f00 Update change logs for 2.0.0-beta.1
8541498a ENYO-5197: Fix MediaSlider hiding knob
216582a0 ENYO-4162: Add preload support to moonstone/VideoPlayer
936762d7 PLAT-52692: Add moonstone/VideoPlayer.MediaControls component
0c21e1d5 ENYO-5216: Fixed header layout
3f86fc54 PLAT-49776: Fix ui/Layout justifyContent and cell overflow
68f146ca Fixed VirtualList not to have two defaultProps
dfad977b PLAT-49776: Allow more flexible usage of Notification and
         SwitchItem
86edec95 ENYO-5201: Update ui/Transition docs
985577ba PLAT-54712: Fix doc errors
46c902e5 ENYO-4977: Add missing min-height support to ExpandableItem
c7185881 PLAT-52107: Improve a11y support in ExpandablePicker,
         DayPicker, and DaySelector
8b757ec5 PLAT-47085: Change moonstone/Input to lock pointer when focused
40547964 ENYO-4977: Set min-height for ExpandableItem
f8b98e47 ENYO-5194: Fix VideoPlayer to render bottom controls after
         playing
03b87706 PLAT-53627: Consolidate ProgressBarTooltip positioning props
730731d5 PLAT-49775: Add moonstone/DayPicker prop dayNameLength
199c0fd1 PLAT-52103: Add aria label props to Picker, DatePicker, and
         TimePicker
4fc96f19 PLAT-49774: Add wrap prop to VirtualList
2cb551fc ENYO-5061: Define the default prop value for `spacing` in
         moonstone/VirtualList
32057815 ENYO-5130: Fixed not showing proper placeholder and
         selectionOverlay in GridListImageItem
126e39fe PLAT-48639: Change spotlight/Spottable to retain focus when
         disabled
23479813 PLAT-53652: Change ui/Cancelable to use stopPropagation
         instead of return values
04b14706 PLAT-52473: Add webos/speech with voice control support
7bbdc529 ENYO-5184: Restore focus after mounting VirtualList
e0cfa6c0 ENYO-5018: Add moonstone/MediaOverlay component
a118b650 PLAT-35655: Add ui/Slider and adopt in moonstone
cac06ff7 PLAT-53067: Move dependencies to React 16.3
1668bffc PLAT-49780: Optimize localized font loading performance
fe215dc9 ENYO-5141: VirtualGridList: Fix showing blank when direction
         prop changed
d124d663 Fix list sampler
188e7403 ENYO-5191: Add core/snapshot module
2db42770 ENYO-5188: Remove tooltipHideDelay prop
e6b46685 ENYO-5186: Fix memoize to forward all args to provided function
795b6a8e ENYO-4501: Fix navigating via 5-way from paging controls
6972a915 PLAT-52971: Fixed lists to support RTL by dynamic language
         changes.
08cad635 PLAT-52105: Add closeButtonAriaLabel to moonstone/Popup
71bf1b44 PLAT-52108: Add props to set aria-label of scroll buttons
3d9ae78e Version value updating
8c35b692 Update change logs for 2.0.0-alpha.8
cd4231ff PLAT-53640: Allow to force to re-render VirtualList items if
         needed
a94e6803 ENYO-5160: Fix VideoPlayer to show controls on 5-way select
fe0f13f2 PLAT-53275: Fix broken link and documentation errors
487f7c7f ENYO-5135: Fix RTL positioning of moonstone/Notification
3d0a6f34 PLAT-52322: Optimize mount performance of ui/Touchable
5f0d47ce PLAT-52106: Add closeButtonAriaLabel prop to moonstone/Panels
ee5fdf49 ENYO-5076: Remove webOS media event from storybook
127b3dad ENYO-5134: Fix ExpandableItem from Applying Open Class When
         Disabled
92348f63 ENYO-4981: Fix TimePicker to support variable length meridiems
3c76ff8c ENYO-5144: Fix ui/ViewManager to send the correct enteringProp
         value
4c081fe9 PLAT-48047: Improve render performance of ui/Placeholder
b9d0f7ec ENYO-5136: Add tooltipSide knob for ProgressBar samples
acd772cf ENYO-5069: Fix the timing to read a11y for ScrollButton
acdf2d52 PLAT-52790: Fix the a11y property of VirtualList
ac80ed91 ENYO-5133: Normalize & fix Babel configuration in Sampler
dcc625a0 PLAT-53082: Fix missing required pragmas for props
0ac9de48 ENYO-5126: Add background knob to sampler
93ce7e17 PLAT-52825: Refactoring to reduce ref usage in VirtualList,
         Scrollable
8aa996a5 PLAT-52582: Change media title to accept node type
bb342545 ENYO-5013: Fix ui/Transition to handle empty children
a2e5268f Version value updating
d2de8d95 Update CHANGELOG
126caf24 ENYO-5127: Fix Scroller RTL position calculation
3fa8241d PLAT-51654: Add timeout support to webos/LS2Request
5a7bab79 Fix CHANGELOG
8bba2f2d ENYO-5093: Guard against document to allow proper prerendering.
5cf213c1 ENYO-5071: Fix ActivityPanels layout after adding panels
dfacb9f1 ENYO-5094: Display overflowing children in slide transition
02ce038f ENYO-5092: Fix navigating out of moonstone/Input via 5-way
63e05475 PLAT-52443: Deprecate `data` prop and add `isDisabledItem` in
         VirtualList
50c2f333 ENYO-4988: VideoPlayer update
9a343180 ENYO-4559: Adjust spotlight partitions and priorities
236901ad ENYO-5054: Update ProgressBar and Slider colors
c1b5bcfe ENYO-5088: Refactor ProgressBarTooltip to use CSS variables
         for positioning
27c64358 ENYO-5056: InputHeader support
989c4bb2 ENYO-5006: Spotlight Hides on Page Down/Up
8d3050de Updated lint option from `--framework` to `--strict`
1b3a996d PLAT-52580: Add blue underline in more button
1ac1cf3a ENYO-5024: Fix Picker to update pressed state when dragging
         off buttons
0b6bb0d9 ENYO-5065: Fix runtime error in ProgressBar QA sample
d55584dd ENYO-5046: Add QA sample with two ExpandableInput instances
c90316b4 PLAT-50771: Cleanup the JSDoc for VirtualList, Scroller, and
         PlaceholderDecorator
89a4ce40 PLAT-51382: Syncing DOM structure and logic between JS version
         and Native version lists
8349ff7e Version value updating
f77edac3 PLAT-52586: Fix ProgressBar tooltip in vertical orientation
795b031f update change logs for 2.0.0-alpha.6
8f820072 ENYO-5085: Fix blurring Input on state update
398b3071 ENYO-5079: Fix spotlight pause-resume behavior for animated
         Popups
d62689dd Revert "Cleanup the JSDoc for VirtualList, Scroller, and
         PlaceholderDecorator (#1510)"
55ad4e62 Cleanup the JSDoc for VirtualList, Scroller, and
         PlaceholderDecorator
f2ad0c72 ENYO-4978: Add Tooltip to ProgressBar
1ab3a5b3 ENYO-5074: Replace `vertical` with `orientation`
d9afb1db ENYO-4998: Add support for custom media components in
         VideoPlayer
daff470f PLAT-49792: Add spotlight/Pause to manage pause state
7ba5d89f ENYO-4919: Add spotlightId prop to Spottable
4aa8858c PLAT-52178: Rename ui/VirtualList prop component to
         itemRenderer
e0e2ece0 ENYO-5072: ComponentOverride should support strings as HTML
         tag names
0c926274 ENYO-5021: Fix styling of moonstone/Scroller paging controls
f9aafc4b ENYO-4964: Fix moonstone/Slider to handle updates to its value
         prop
e2413d3a remove jsdoc comment for non-exported method
9e854b30 PLAT-45660: Add small prop to moonstone/Input
3e5727ff PLAT-50128: Add touch-dragging support to ui/Scrollable
28e22bbc PLAT-48937: Change RadioItem icon styling for new GUI design
86a7d885 PLAT-48940: Changed FormCheckbox icon styling for new GUI
         design
9282b1f1 Removed unused `onScrollbarVisibility` prop from Scrollable
2884412c PLAT-51591: Remove core/factory
cfaadca2 ENYO-5060: Standardize styling and exports of
         moonstone/DaySelector
9aa854c5 PLAT-48641 Change default focus in lists (First -> Selected)
48bd2402 PLAT-48634: Add accessibility props for IncrementSlider
93724f60 ENYO-5022: Slider Set ActiveProp to Pressed
4f96019d PLAT-51741: VirtualList/Scroller: Revising components exporting
3401aa7c ENYO-4918: Fix ui/Transition 'clip' direction animations
addf417a PLAT-51759: Remove moonstone/Slider and
         moonstone/IncrementSlider factories
da62434f UI Migration: VirtualList and Scroller
99b187ea ENYO-5031: Fix GridListImageItem to hide overlay checkmark
         icon on focus when unselected
e194106c PLAT-50488: Fix moonstone/Input to not clip some glyphs
d44d9ffa PLAT-45996: Optimize ExpandableItem Re-renders
34de9c02 Version value updating
d8ec6cb8 update change logs for 2.0.0-alpha.5
ed08a148 ENYO-4956: Change ContextualPopup to not restore last-focused
         child
3e1a3651 PLAT-51329: Add badges to enact-cli and enact readmes
371215b6 PLAT-48714: Fix invalid reference to core/handle.stop
64651647 ENYO-4963: Add correct percent formatting in Slider
24302c01 PLAT-48638: Normalize the Button taparea
23c23f0d ENYO-4960: Prevent unnecessary updates due to focus changes
f51ba687 PLAT-48714: Migrate Marquee to UI
60970ab1 ENYO-5035: Move .marquee back to moonstone/Button
5f7c336f ENYO-4089: Remove moonstone/VirtualList.GridListImageItem
966a7520 Version value updating
47fcb1d6 update change logs for 1.15.0
fbd599c1 PLAT-51592: Deprecate core/util.childrenEquals and
         moonstone/Marquee.MarqueeText
3233bae5 ENYO-5043: Fix GridListImageItem to display correctly
14677f23 ENYO-5003: Remove childrenEquals util method
e832548c ENYO-5014: Fix Pure to compare children by strict equality
632e4f7b PLAT-51023: update new components samples and tests for 2.x
421d9fc7 ENYO-5010: Remove color knob from moonstone/Button sample
4fe18b90 PLAT-50258: Show scrollbars with disabled page controls for
         the edge case
3c7b7fe6 PLAT-49073: Migrate localized font generation to UI
9c8029fe Version value updating
40092c24 Update CHANGELOG
e6811189 Update CHANGELOG
bce4a518 PLAT-51299: Update changelog for SlotItem
ffd95ac2 PLAT-50493: Deprecate Holdable and Pressable and fix other
         deprecation messages
8d251fc9 ENYO-4314: Fix unnecessary rendering of ViewManager views on
         mount
0ac956d7 PLAT-49048: Deprecate core/factory
e740484f PLAT-44250: Fix changelog
921e26ef PLAT-44250: Add Drag Support
261d0e42 PLAT-49066: Migrate ToggleItem component to UI
d6f474b3 PLAT-50403: Update references to old github repo
a573ecd6 pass disabled prop to `DaySelector`
d532bc31 PLAT-50769: Remove moonstone/VirtualFlexList
4094c77d PLAT-50769: Deprecate moonstone/VirtualFlexList
aac880e5 Version value updating
9d3448a9 update change logs for 2.0.0-alpha.4
6ab227f8 ENYO-5025: Fixes ToggleItems to be toggleable in 5-way mode
e75bae6e PLAT-45602: Button noAnimation Deprecation Fix
333d8b90 PLAT-45602: Remove Button noAnimation Prop for develop
b879973d PLAT-45602: Deprecate Button noAnimation Prop for 1.x
cc3a1836 ENYO-5016: Fix applying the same classes multiple times
52274045 PLAT-49065: Migrate Item and related components to UI
aaf4a89d ENYO-4935: Fix Spottable to allow onBlur to fire when becoming
         disabled
2f9f9a1b Add the useNativeScroll flag to the appinfo.json of Enact
         sampler
56aa8cf8 Fix lint error
02e6dd1e PLAT-50595: UI-Migration Button, Icon, IconButton docs/hoc
         cleanup
2cf5e135 ENYO-4888: Update Lerna to current release
315dab74 PLAT-49062: Add ui/ToggleIcon component to support Checkbox
         and Switch
93d0f843 ENYO-4994: IconButton Update Props As Required
03282685 PLAT-50501: Updated VirtualList/Scroller docs
27a24466 PLAT-49743: Change ui/Repeater to generate key for string type
         only
2961918c First attempt at spinner migration
93417606 PLAT-27835: Add moonstone/DaySelector component
1cc2fa67 PLAT-47093: Fix returning the wrong time when starting DST
02136c43 PLAT-48541: Improve core submodule performance
8ad03760 PLAT-50337: Fix passing invalid proportionPlayed value to
         MediaSlider
66be53f3 Fix Travis errors
e5337ef8 PLAT-49067: Migrate ProgressBar to UI
83f86739 PLAT-49061: Migrate Image to UI
99e4df2e PLAT-49058: Migrate BodyText to ui
729abd7b ENYO-5007: Update sampler shrinkwrap file
d84743a9 PLAT-48259: Upgrade to React 16
22197179 PLAT-49870: Add developer guidance on usage of core/kind
e0c75fcb PLAT-49671: Add Accessibility Support in Enact documentation
e643cb7a ENYO-4979: Focus a list item in VirtualListNative when
         creating it if needed
ad614dce Version value updating
c1448e00 Update some crufty docs
356448dd ENYO-4089: Deprecate VirtualGridList.GridListImageItem
13dcad3e ENYO-4937: Fix focusing Expandable title in pointer mode
63ee5f75 PLAT-48116: Optimize Marquee's styling and measurement
         technique
ad0cfa1f PLAT-48115: Change ui/Layout align property to support
         multiple dimensions
401b936a PLAT-31616: Improvements to be made to docs processes
6ee4f9b6 PLAT-27834: Add moonstone/EditableIntegerPicker component
bfe0874b Fix doc for core/handle/log method
5f473101 update changelogs for 2.0.0-alpha.3
19360ab7 Merge 1.13.3 into develop
a38d0a53 PLAT-48718: removed deprecated props/option
a221dd0f Travis fix for selectively disabling newly-enabled ESLint
         react/jsx-no-bind rule in test files.
42945c6f PLAT-47659: Handle global iLib data objects in Enact loading
5f63ae2a ENYO-4980: fixed VirtualListNative to pause Spotlight when
         scrolled by page keys
fb7fb580 PLAT-39345: Refactors base Icon and Button components into ui
87f7100e ENYO-4806: Focus a list item when creaing it
8087957d PLAT-44251: Add flick gesture
d3f82329 ENYO-4922: Removed a redundant Job in Scrollable for scrollbar
         thumbs
41cb661b ENYO-4620: Prevent to infinite function call when total item
         size is same with client size
609b63cc PLAT-47396: Add support for determining resolution from root
         node
84dcab86 Use develop branch of enact-dev on 2.x develop branch of enact
967cd30b ENYO-4729: Fixed to sync scroll position when clientSize
         changed
12e4d4ee Merge 1.8.0
a750fc72 ENYO-4578: Fix returning localized text using DurationFmt
3983e868 Add CHANGELOG headers
9e544a77 Version value updating
dba9e60c Updates CHANGELOG files
00db1a87 PLAT-44656/PLAT-43821: Add Scroller and VirtualList removed
         moonstone style
46378201 Version value updating
bf01b37c Update CHANGELOG
04c49a4a Update CHANGELOG
281b525a Update CHANGELOG
c4743353 PLAT-43812: Add touch support
c7b72c7a PLAT-42970: Add Layout component
95654953 Sync up 1.7.0
5f2ef839 Revert "ENYO-4484: Update Moonstone Font Metadata (#1027)"
605fe9f6 ENYO-4484: Update Moonstone Font Metadata

:Testing Performed:
Verf built

:QA Notes:

:Issues Addressed:
[PLAT-64020] Snapshot not working for Enact Browser on OSE
[ENYO-5538] [webOS OSE]: Create CCC for latest Enact Devtools
[ENYO-5537] [webOS OSE]: Create CCC for Enact 2.0.1
[PLAT-64234] [OSE] CCC: enact-framework=v2.0.1,r3
             enact-dev-native=v1.0.10,r6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stsvilik @prabhu @isaacs @shibinrajumathew