Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not check errors with instanceof. #209

Closed
wants to merge 2 commits into from
Closed

fix: do not check errors with instanceof. #209

wants to merge 2 commits into from

Commits on Feb 4, 2020

  1. fix: do not check errors with instanceof. 

    It's probably safe enough to assume existance of the `.stack` property
on the Error object.

This should avoid the cross-VM type issues we see in Jest.

Fixes isaacs#208
    @aslushnikov
    aslushnikov committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    02043b7 View commit details
    Browse the repository at this point in the history

  2. address comments

    @aslushnikov
    aslushnikov authored Feb 4, 2020
    Configuration menu
    Copy the full SHA
    36e0cbe View commit details
    Browse the repository at this point in the history