Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the relative index used to make compressed SLCs #452

Merged

Conversation

scottstanie
Copy link
Collaborator

Discovered this after repeated batch runs of disp-s1, manually passing in stacks with compressed SLCs:

  File "/u/aurora-r0/staniewi/repos/dolphin/src/dolphin/workflows/wrapped_phase.py", line 171, in run
    ) = sequential.run_wrapped_phase_sequential(
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/u/aurora-r0/staniewi/repos/dolphin/src/dolphin/workflows/sequential.py", line 114, in run_wrapped_phase_sequential
    run_wrapped_phase_single(
  File "/u/aurora-r0/staniewi/repos/dolphin/src/dolphin/_decorators.py", line 106, in wrapper
    result = func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/u/aurora-r0/staniewi/repos/dolphin/src/dolphin/workflows/single.py", line 239, in run_wrapped_phase_single
    cur_comp_slc = compress(
                   ^^^^^^^^^
  File "/u/aurora-r0/staniewi/repos/dolphin/src/dolphin/phase_link/_compress.py", line 39, in compress
    pl_referenced = pl_cpx_phase * pl_cpx_phase[reference_idx][None, :, :].conj()
                                   ~~~~~~~~~~~~^^^^^^^^^^^^^^^
IndexError: index 17 is out of bounds for axis 0 with size 15

The "extra_reference_index" asked for image index 17; there were 15 real, 5 compressed.

This fixes the phase_link.compress call to adjust for the real SLC offset.

Verified this worked by checking OPERA_CSLC * compressed_slc.conj() for the corresponding dates:

image

@scottstanie scottstanie merged commit 70b0a95 into isce-framework:main Oct 15, 2024
6 checks passed
@scottstanie scottstanie deleted the fix-extra-reference-offset branch October 15, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant