Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comment explaining why Util.h only has one function in it #2028

Merged
merged 6 commits into from
Jul 2, 2020
Merged

Added comment explaining why Util.h only has one function in it #2028

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b2159a
Removed visualization::gui::util namespace
prewettg Jun 26, 2020
727ac8c
Style fixes
prewettg Jun 26, 2020
a641531
Added comment explaining why gui/Util.h only has one function in it.
prewettg Jun 30, 2020
54e1079
Merge branch 'master' into prewettg/remove-gui-util-namespace
prewettg Jun 30, 2020
7b50471
Style checker didn't like my comment
prewettg Jul 1, 2020
1e0cc67
Merge branch 'master' into prewettg/remove-gui-util-namespace
prewettg Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/open3d/visualization/gui/Util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ namespace gui {

class Color;

// This one function is here, because ImVec4 requires imgui.h, and can't be
// forward-declared because we need to know the size, since it is a return
// value. Since imgui.h is an implementation detail, we can't put this function
// in Color or it would pull in imgui.h pretty much everywhere that gui is used.
ImVec4 colorToImgui(const Color& color);

} // namespace gui
Expand Down