-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IO for NPZ files for Tensor-based TriangleMeshes #6019
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Texture maps are now supported. Try this updated script:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @errissa)
cpp/open3d/t/io/TriangleMeshIO.cpp
line 243 at r2 (raw file):
} if (mesh.HasTriangleAttr("texture_uvs")) { mesh_attributes["uvmap"] = mesh.GetTriangleAttr("texture_uvs");
Maybe we want to change this one.
I think the options we have are
triangle_texture_uvs
(+valid identifier -multiple underscores)
triangle.texture_uvs
(+like accessing an o3d attribute -can be saved to npz but not a valid identifier)
triangle__texture_uvs
(+valid identifier -even more _)
More options after TriangleMesh->Mesh
face{_,.,__}texture_uvs
What do you think? @errissa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @errissa)
cpp/open3d/t/io/TriangleMeshIO.cpp
line 243 at r2 (raw file):
Previously, benjaminum (Benjamin Ummenhofer) wrote…
Maybe we want to change this one.
I think the options we have are
triangle_texture_uvs
(+valid identifier -multiple underscores)
triangle.texture_uvs
(+like accessing an o3d attribute -can be saved to npz but not a valid identifier)
triangle__texture_uvs
(+valid identifier -even more _)More options after TriangleMesh->Mesh
face{_,.,__}texture_uvs
What do you think? @errissa
The mentioned options apply to all attributes
I thought we might want to change this one. It doesn't fit any other patterns we're using. I think the simplest is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion
* Add IO to/from NPZ files * Add texture maps and generic attriubtes to IO * Style fixes * Read/write material name and fix read with metallic texture * Add unit test for TriangleMesh NPZ IO * Apply style fixes * Rename uvmap to triangle_texture_uvs * Style fixes
The following script tests the basic functionality:
This change is