Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
During my usage of the ISS Keypoint functionality I encountered some random crashes, which I tried to find the reason for. I explained it here: #4847 (comment)
Secondly there seems to be a more subtile issue in
ComputeModelResolution
, as the original code only checks for "more than 0" neighbors, but as the query point itself will always be present, this condition will never fail. I adjusted the condition here to>= 2
.Eventually I applied some std algorithms instead of manually written loops, which makes the intent of the code more obvious.
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
Yes, but it crashes due to some strange errors. But resharper is applying the clang-format file anyways.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
This is the error popup
Those are some of the entries of kp_indices
This change is