Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nanoflann to version 1.5.0 #6216

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

roehling
Copy link
Contributor

@roehling roehling commented Jun 18, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Maintenance of third-party dependencies, in this case nanoflann

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This PR updates Open3D to build with the latest nanoflann version 1.5.0. Note that Jose did some refactoring, so this PR makes Open3D incompatible with older nanoflann releases.


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jun 18, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@roehling
Copy link
Contributor Author

It looks like the unit test is failing for the new Nanoflann. I'll convert this into a Draft pending further investigation.

@roehling roehling marked this pull request as draft June 19, 2023 07:19
The (ignored) checks argument has been removed
@roehling roehling marked this pull request as ready for review June 27, 2023 11:26
@roehling
Copy link
Contributor Author

I found and fixed the issue; the PR is ready for review now.

@ssheorey
Copy link
Member

Note that Jose did some refactoring, so this PR makes Open3D incompatible with older nanoflann releases.

In that case, can you add a check in find_dependencies.cmake that gives a fatal error if USE_SYSTEM_NANOFLANN but the version is less than 1.5?

@ssheorey ssheorey self-requested a review June 29, 2023 19:39
@roehling
Copy link
Contributor Author

Good point.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always @roehling !

@ssheorey ssheorey merged commit f492ff5 into isl-org:master Jun 30, 2023
@roehling roehling deleted the nanoflann-1.5 branch June 30, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants