-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voxel Downsample for Tensor interface #6249
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @ssheorey, @theNded, and @yxlao)
cpp/pybind/t/geometry/pointcloud.cpp
line 220 at r2 (raw file):
"Downsamples a point cloud with a specified voxel size and a " "reduction type.", "voxel_size"_a, "reduction"_a = "mean");
Please update the documentation in google format and add a minimal example. See compute_convex_hull
as an example.
Thank you!!! 😇
Done. We could also use some time (and maybe GPT) to polish/fix the docs, including
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the docstring fixes!
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @ssheorey and @yxlao)
This PR addresses #6172 #5519 and allows averaging properties in voxel downsample. Previously, points are simply put at grid corners.
To achieve this, the operation
IndexAdd_
(similar for pytorch) for tensors is introduced.An alternative would be reusing Benjamin's Voxel Pooling. We may revisit this later.
Now the behavior is the same as legacy, but there is a slight voxel coordinate offset due to implementation discrepancies. The legacy version computes a bound that slightly shifts the voxels.
Next TODOs
This change is