Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6291 and #6236 #6305

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fixes #6291 and #6236 #6305

merged 3 commits into from
Aug 15, 2023

Conversation

theNded
Copy link
Contributor

@theNded theNded commented Aug 11, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Fixes #6291 and #6236


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Aug 11, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@theNded theNded merged commit 1012819 into isl-org:master Aug 15, 2023
36 checks passed
Copy link
Contributor

@saurabheights saurabheights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please do see one new comment.

@@ -64,23 +64,24 @@ class RANSACResult {
};

// Calculates the number of inliers given a list of points and a plane model,
// and the total distance between the inliers and the plane. These numbers are
// then used to evaluate how well the plane model fits the given points.
// and the total squared point-to-plane distance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the total squared point-to-plane distance be root mean squared point-to-plane distance? Not a major issue though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, 1 minute late :D .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know and I can push this change when making other documentation PRs. This anyways is not getting rendered to C++ docs, so probably needs more work to make it doxygen compatible - http://www.open3d.org/docs/release/cpp_api/namespaceopen3d_1_1geometry.html#a5013df32089b6fb7222d04535759b7d4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: The comments in .cpp files are for code authors (how does it work?) and comments in header files (Doxygen compatible) are for API users (what does it do, inputs and output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RMSE Calculation in EvaluateRANSACBasedOnDistance Method
3 participants