Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seg fault in t::geometry::TriangleMesh::SelectByIndex for negative index #6489

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

nsaiapova
Copy link
Contributor

Sorry about the issue. It was introduced by #6415. When I moved from forbidding the invalid indices to ignoring them, I forgot to actually ignore them, which led to a possible invalid data access by a negative index.
That went unnoticed, as the test was only in python and was flaky.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #

Motivation and Context

A data access by negative index.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.
    FYI @ssheorey

Copy link

update-docs bot commented Nov 14, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick bugfix!

@ssheorey ssheorey merged commit 9b45f01 into isl-org:master Nov 14, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants