Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Near Clip and Far Clip parameters to the Python Bindings #6520

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

zalo
Copy link
Contributor

@zalo zalo commented Nov 30, 2023

Add optional args to set the NearClip and FarClip of the camera in the Offscreen Renderer.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation, Context, and Description

Open3D Python doesn't currently expose a method for the OffscreenRenderer to convert depth units to absolute units, since all camera setting methods automatically normalize to the scene bounding box (without exposing those normalized values anywhere). This simple PR optionally exposes those options to enable depth to be output in absolute units.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Copy link

update-docs bot commented Nov 30, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey merged commit cb947b4 into isl-org:main Dec 11, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants