Delete takes care of unscheduling #23
Conversation
|
Wasn't sure the best way to submit this PR as its tests fail without the revisions present in #22 so I cherry-picked the two revisions in that branch that are relevant. |
And SessionAuthenticationMiddleware class is removed in 2.0 as it provided no functionality since session authentication is unconditionally enabled in Django 1.10.
In python2.x d.keys() returned a list. With python3.x, d.keys() returns a dict_keys object which behaves a lot more like a set than a list. As such, it can't be indexed. Changing d.keys() to list(d)) will return a list of keys on both python2.x and python3.x without making any copies. reference: https://stackoverflow.com/questions/17322668/typeerror-dict-keys-object-does-not-support-indexing
delete takes care of unscheduling admin uses model.delete instead of model.all.delete tests updated
tom-price
force-pushed
the
unschedule-delete_after_ttl
branch
from
4c3b3e3 to
12f6a5d
Compare
|
@tom-price Some great work! After we update the README and get a new pypi version out there, @bashhack and I are going to continue to keep an eye on this project for issues and PRs, but it's not going to be a high priority for us. I think the 3 of us together could easily make sure this project stays relevant and up to date with it's current features. |
|
Sure, I'd be happy to help. I'm using this as part of a longer term project of my own so I'll also be paying attention to it, rq-scheduler, etc.. As a heads up, I've been working on adding args and kwargs support and will hopefully finish sometime later this week. A real blocker has been adding tests that assert the args and kwargs are getting properly passed all the way through. |
|
@oudeismetis @tom-price Is |
|
@jteppinette, Unfortunately I'm not sure. I've not been in touch with the other maintainers and I've not done that part before. I've got a couple changes ready to go and continue to use a fork of this project on a daily basis in my own work, so it's not forgotten about. |
|
@tom-price It looks like someone is maintaining a separate PyPI package with this update and .. something else .. (1.1.3). https://pypi.org/project/readwise-django-rq-scheduler/#description |
|
Interesting. I'll make a renewed effort to get in touch with the other maintainers. There are some outstanding PRs including my own, #24, that seem ready, or would be with little work, for merging in and publishing. |
|
@oudeismetis @tom-price We should update PyPI ownership on this package. I am using this package at work, so I would be willing to do it. |
A revised version of PR #20 simplified to only include revisions to how deletion works (no admin validation on time) that'll be safe to merge after PR #22.