Fix several php8 errors (#2426)

isotope · Mar 27, 2023 · 1f1bd06 · 1f1bd06
1 parent 66d40f6
commit 1f1bd06
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/system/modules/isotope/library/Isotope/CheckoutStep/Address.php b/system/modules/isotope/library/Isotope/CheckoutStep/Address.php
@@ -324,7 +324,7 @@ protected function getAddressOptions($arrFields = null)
                     $arrOptions[] = [
                         'value'   => $objAddress->id,
                         'label'   => $objAddress->generate($arrFields),
-                        'default' => $objAddress->id == $objDefault->id ? '1' : '',
+                        'default' => $objAddress->id == ($objDefault->id ?? false) ? '1' : '',
                     ];
                 }
             }

diff --git a/system/modules/isotope/library/Isotope/Model/Attribute/AbstractAttributeWithOptions.php b/system/modules/isotope/library/Isotope/Model/Attribute/AbstractAttributeWithOptions.php
@@ -95,7 +95,7 @@ public function getOptionsForWidget(IsotopeProduct $objProduct = null)
                         foreach ($options as $option) {
                             $option['label'] = Translation::get($option['label']);
 
-                            if ($option['group']) {
+                            if ($option['group'] ?? false) {
                                 $group = $option['label'];
                                 continue;
                             }

diff --git a/system/modules/isotope/library/Isotope/Model/Product/Standard.php b/system/modules/isotope/library/Isotope/Model/Product/Standard.php
@@ -708,7 +708,7 @@ protected function generateProductOptionWidget($strField, &$arrVariantOptions, &
                         } else {
                             $blankOption = $k;
                         }
-                    } elseif (!\in_array($option['value'], $arrOptions) && !$option['group']) {
+                    } elseif (!\in_array($option['value'], $arrOptions) && !($option['group'] ?? false)) {
                         unset($arrField['options'][$k]);
                     }
                 }

diff --git a/system/modules/isotope_rules/library/Isotope/Rules.php b/system/modules/isotope_rules/library/Isotope/Rules.php
@@ -258,12 +258,12 @@ public function getCouponForm($objModule)
         $objTemplate->usedCoupons = $arrCoupons;
         $objTemplate->rules = $objRules;
 
-        if ($_SESSION['COUPON_FAILED'][$objModule->id] != '') {
+        if (!empty($_SESSION['COUPON_FAILED'][$objModule->id])) {
             $objTemplate->message = $_SESSION['COUPON_FAILED'][$objModule->id];
             $objTemplate->mclass = 'failed';
             unset($_SESSION['COUPON_FAILED']);
 
-        } elseif ($_SESSION['COUPON_SUCCESS'][$objModule->id] != '') {
+        } elseif (!empty($_SESSION['COUPON_SUCCESS'][$objModule->id])) {
             $objTemplate->message = $_SESSION['COUPON_SUCCESS'][$objModule->id];
             $objTemplate->mclass = 'success';
             unset($_SESSION['COUPON_SUCCESS']);