Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPClient instead of java.net.http for Java 8 compatibility #42

Merged
merged 27 commits into from
Dec 1, 2023

Conversation

stoerr
Copy link
Member

@stoerr stoerr commented Dec 1, 2023

Continues #31 .

To be really backwards compatible to AEM 6.5.x we also support Java 8. That meant replacing java.net.http by HttpClient 5

The PR also includes various small fixes in the AEM dialogs and some prompting improvements.

There is also an important fix: OpenAI introduced a new field in the response and the completion wasn't prepared for that.

@stoerr stoerr merged commit 6afc8ae into develop Dec 1, 2023
2 checks passed
@stoerr stoerr deleted the feature/httpclient5-java8 branch December 1, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant