Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package dependencies and Babel configurations #295

Closed
wants to merge 1 commit into from

Conversation

zodman
Copy link

@zodman zodman commented Jul 5, 2024


> babel-plugin-istanbul@6.1.1 pretest
> standard && npm run release


> babel-plugin-istanbul@6.1.1 release
> babel src --out-dir lib

Successfully compiled 2 files with Babel (167ms).

> babel-plugin-istanbul@6.1.1 test
> cross-env NODE_ENV=test nyc --reporter=lcov --reporter=text mocha --timeout 5000 test/*.js



  babel-plugin-istanbul
    Babel plugin config
      ✔ should instrument file if shouldSkip returns false (56ms)
      ✔ should not instrument file if shouldSkip returns true
      ✔ should call onCover callback
      local node_modules
        ✔ should instrument file if shouldSkip returns false
        ✔ should not instrument file if shouldSkip returns true
    source maps
      ✔ should use inline source map
      ✔ should not use inline source map if inputSourceMap is set to false
      ✔ should use provided source map
    instrument options
      ✔ should honor coverageVariable option
      ✔ should honor coverageGlobalScope option
      ✔ should honor coverageGlobalScope option
      ✔ should honor ignoreClassMethods option
    package.json "nyc" config
      process.env.NYC_CONFIG is set
        ✔ should instrument file if shouldSkip returns false
        ✔ should not instrument file if shouldSkip returns true
      process.env.NYC_CONFIG is not set
        ✔ should instrument file if shouldSkip returns false (349ms)
        ✔ should not instrument file if shouldSkip returns true
        ✔ should load config using cwd (1094ms)
    regression tests
      ✔ should instrument: export const foo = () => {}
      ✔ should not conflict with transform-modules-commonjs (45ms)


  19 passing (2s)

-------------------------|---------|----------|---------|---------|-------------------
File                     | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-------------------------|---------|----------|---------|---------|-------------------
All files                |     100 |      100 |     100 |     100 |                   
 index.js                |     100 |      100 |     100 |     100 |                   
 load-nyc-config-sync.js |     100 |      100 |     100 |     100 |                   
-------------------------|---------|----------|---------|---------|-------------------

@SimenB
Copy link
Member

SimenB commented Jul 5, 2024

CI is very unhappy here 😅

Some of the updates landed in #292, but happy to update more deps if you can make CI pass 🙂

@anomiex
Copy link

anomiex commented Jul 10, 2024

I suspect you'll need to merge the changes from master, then bump the node version to 18 in

"node": ">=12"

drop the tests against node <18 at
node: [12, 14, 16, 18, 20, 22]

and bump the node-version in a few other places too

@zodman
Copy link
Author

zodman commented Jul 31, 2024

working on it ...

@SimenB
Copy link
Member

SimenB commented Jul 31, 2024

FYI, I won't merge if it drops Node 16 as I need that version to be supported in Jest. Which probably means test-exclude needs to wait a cycle

@anomiex
Copy link

anomiex commented Aug 3, 2024

That's very unfortunate, since that will prevent fixing #294, which means Jest will be continuing to raise the scary deprecation warnings for everyone.

I see test-exclude is also under istanbuljs. Would you, @SimenB, be willing to fix that package to restore Node 16 compat since that's a requirement for you? At a quick glance, despite istanbuljs/test-exclude#56 saying that updating deps was the reason for making Node 18 the minimum, I don't see any deps that don't say they support Node 16.

@zodman
Copy link
Author

zodman commented Aug 5, 2024

I saw the update to version 7 what it was something I lookup thanks!

@zodman zodman closed this Aug 5, 2024
@zodman zodman deleted the upgrade-packages branch August 5, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants