feat: Add .cjs, .mjs, .ts, .tsx, .jsx to default extensions
#1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103
I don't want to pull TypeScript into the devDependencies so I'm not sure if this is going to get testing. Maybe we could put regular JS into files of these extensions?
The fact that
extensionwas missing from thenyc reportcommand is minor - only effected thenyc report --helpoutput. Now that the default is non-empty it will matter. I'd like to look into creating groups of flags - for example a shared function which adds all flags that apply totest-exclude. That is not part of this.