Fix URL to default excludes in README.md #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -172,7 +172,7 @@ You can also specify negated paths in the `exclude` array, by prefixing them wit | |||
| Negated paths can restore paths that have been already been excluded in the `exclude` array. | |||
| Multiple `exclude` globs can be specified on the command line, each must follow a `--exclude`, `-x` switch. | |||
|
|
|||
| The default `exclude` list is defined in the [test-exclude module](https://github.com/istanbuljs/istanbuljs/blob/master/packages/test-exclude/default-exclude.js). | |||
| The default `exclude` list is defined in the [test-exclude module](https://github.com/istanbuljs/test-exclude/blob/master/default-exclude.js). | |||
There was a problem hiding this comment.
Good catch on the move, though test-exclude will soon be altered to pull the default from our shared schema module so I'd prefer pointing to the final location.
Suggested change
| The default `exclude` list is defined in the [test-exclude module](https://github.com/istanbuljs/test-exclude/blob/master/default-exclude.js). | |
| The default `exclude` list is defined in the [@istanbuljs/schema module](https://github.com/istanbuljs/schema/blob/master/default-exclude.js). |
Also removes some trailing whitespace and corrects a spelling mistake.
|
Applied the suggestion. It also removes some trailing whitespace and fixes a spelling mistake now. |
|
Merged, thanks for this contribution! |
coreyfarrell
added a commit
to coreyfarrell/nyc
that referenced
this pull request
Nov 7, 2019
default-exclude list has moved, missed a link in istanbuljs#1214. Fixes istanbuljs#1219
coreyfarrell
added a commit
that referenced
this pull request
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.