Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for per file coverage checking #591

Merged
merged 1 commit into from
Jul 5, 2017
Merged

added support for per file coverage checking #591

merged 1 commit into from
Jul 5, 2017

Conversation

AmShaegar13
Copy link
Contributor

Implements #468

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3e9f20d on 1and1:coverage_per_file into ** on istanbuljs:master**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3e9f20d on 1and1:coverage_per_file into ** on istanbuljs:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3e9f20d on 1and1:coverage_per_file into ** on istanbuljs:master**.

@coveralls
Copy link

coveralls commented Jun 2, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling 3e9f20d on 1and1:coverage_per_file into ** on istanbuljs:master**.

@bcoe
Copy link
Member

bcoe commented Jun 2, 2017

@AmShaegar13 clever, love it 👍

JaKXz
JaKXz approved these changes Jun 3, 2017
View reviewed changes
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bcoe
Copy link
Member

bcoe commented Jun 10, 2017

@AmShaegar13 will try to get this landed this weekend.

@JaKXz JaKXz mentioned this pull request Jun 15, 2017
Closed
@AmShaegar13
Copy link
Contributor Author

@bcoe Any news?

@bcoe bcoe merged commit bbadc1f into istanbuljs:master Jul 5, 2017
@bcoe
Copy link
Member

bcoe commented Jul 5, 2017

@AmShaegar13 great work, love how simple this implementation was.

@AmShaegar13
Copy link
Contributor Author

Thanks!

@bcoe
Copy link
Member

bcoe commented Jul 16, 2017

@AmShaegar13 this is now available if you run npm i nyc@next mind taking it for a spin and letting me know if everything works as expected on your projects?

@AmShaegar13
Copy link
Contributor Author

@bcoe works like expected in version 11.1.0, thanks!

@bcoe
Copy link
Member

bcoe commented Jul 29, 2017

@AmShaegar13 this awesome new feature is now live if you install the latest version of nyc.

@renovate renovate bot mentioned this pull request Mar 21, 2018
Closed
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AmShaegar13 @coveralls @bcoe @JaKXz