Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #758

Merged
merged 1 commit into from
Dec 31, 2017
Merged

Fix typo #758

merged 1 commit into from
Dec 31, 2017

Conversation

hkdnet
Copy link
Contributor

@hkdnet hkdnet commented Dec 27, 2017

https://github.com/yargs/yargs/blob/master/docs/api.md#global

Options default to being global.

This patch changes reporter from global to not global.
It may break something. However, the broken behavior is not intended.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b2d25a2 on hkdnet:fix into ** on istanbuljs:master**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b2d25a2 on hkdnet:fix into ** on istanbuljs:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b2d25a2 on hkdnet:fix into ** on istanbuljs:master**.

@bcoe bcoe merged commit 6a734b6 into istanbuljs:master Dec 31, 2017
@bcoe
Copy link
Member

bcoe commented Dec 31, 2017

@hkdnet thanks for catching this; always appreciate contributions.

@hkdnet hkdnet deleted the fix branch December 31, 2017 04:31
@bcoe
Copy link
Member

bcoe commented Feb 13, 2018

@hkdnet please try npm i nyc@next which should have your fix; let me know if you run into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants