feat: Implemented Puppeteer to V8 Class #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
approved these changes
Feb 24, 2018
| return this.coverageInfo.map(coverageItem => { | ||
| return { | ||
| scriptId: id++, | ||
| url: coverageItem.url, |
There was a problem hiding this comment.
once Robert finishes his work, we'll want to store the final path that will be saved to disk rather than the original URL.
I'm fine with landing it without this at the outset, just noting here that we need to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
PuppeteerToV8class with a setter function for setting thecoverageInfo, and aconvertCoveragefunction that uses amapfunction to go through and convert from the Puppeteer to V8 format. Also implemented the tests that are handled byPuppeteerToV8without the need ofOutputFiles(which will handle file renaming and inline JS naming).