-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented Puppeteer to V8 Class #4
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5b654ed
Made basic puppeteer to V8 logic work
vkoves 309a6b7
Refactored puppeteer-to-v8 architecture
vkoves 6710321
Wrote proper test for range translation
vkoves c612d61
Added basic test to verify scriptId is generated
vkoves 6e3ebd2
Fixed standard
vkoves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,24 @@ | ||
class PuppeteerToV8 { | ||
// constructor () {} | ||
} | ||
constructor (coverageInfo) { | ||
this.coverageInfo = coverageInfo | ||
} | ||
|
||
setCoverageInfo (coverageInfo) { | ||
this.coverageInfo = coverageInfo | ||
} | ||
|
||
module.exports = () => { | ||
return new PuppeteerToV8() | ||
convertCoverage () { | ||
// Iterate through coverage info and create IDs | ||
let id = 0 | ||
|
||
return this.coverageInfo.map(coverageItem => { | ||
return { | ||
scriptId: id++, | ||
url: coverageItem.url, | ||
functions: { ranges: coverageItem.ranges } | ||
} | ||
}) | ||
} | ||
} | ||
|
||
module.exports = () => new PuppeteerToV8() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once Robert finishes his work, we'll want to store the final path that will be saved to disk rather than the original URL.
I'm fine with landing it without this at the outset, just noting here that we need to update.