Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an incorrect statement #2979

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix an incorrect statement #2979

merged 2 commits into from
Oct 31, 2023

Conversation

peterj
Copy link
Member

@peterj peterj commented Oct 30, 2023

Fixing an incorrect comment on the SIDECAR_INBOUND line.

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
@peterj peterj requested a review from a team as a code owner October 30, 2023 22:44
@istio-policy-bot
Copy link

😊 Welcome @peterj! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2023
@peterj peterj added the release-notes-none Indicates a PR that does not require release notes. label Oct 30, 2023
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@ericvn
Copy link

ericvn commented Oct 31, 2023

/cherrypick release-1.20

@istio-testing
Copy link
Collaborator

@ericvn: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing merged commit b693dce into istio:master Oct 31, 2023
6 checks passed
@istio-testing
Copy link
Collaborator

@ericvn: new pull request created: #2980

In response to this:

/cherrypick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants