add cluster domain to meshConfig #3265
Conversation
|
😊 Welcome @nicole-lihui! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
nicole-lihui
force-pushed
the
add-clusterDomain
branch
from
862d8b2
to
27c8894
Compare
There was a problem hiding this comment.
Previous discussion in #3234.
This needs some clarity on how this will be implemented. Currently this is read by Istiod and the agent. What is the plan to get these pieces of info there, how will it handle updates, what is the migration path, etc?
If we are adding this it cannot just be a hint to analyze, it needs to replace the existing ways to configure it
|
Hi @costinm,What do you think about this? I am currently facing an issue with the usage of the cluster DNS domain. I want to define the cluster DNS domain as a mesh-level configuration, not just within Here, I also have another thought: in a multi-cluster setup, theoretically, each cluster can have its own separate domain. I am wondering if we need to consider this, similar to how |
|
@howardjohn @costinm @hzxuzhonghu |
istio-testing
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
later needs to read meshconfig.custerDomain from istio/istio#51064