Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Implement Release channels #2797

Closed

Conversation

whitneygriffith
Copy link

@whitneygriffith whitneygriffith commented Jan 31, 2024

Part of #173

  • Separate YAMLs are created for each release channel with its appropriate APIs and API versions
  • Separate YAMLs are created for each release channel with its appropriate APIs and API versions
  • CRDs in each channel has its appropriate storage and served versions

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 31, 2024
@istio-policy-bot
Copy link

😊 Welcome @whitneygriffith! This is either your first contribution to the Istio tools repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2024
cmd/protoc-gen-crd/main.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/main.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/main.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/main.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/main.go Outdated Show resolved Hide resolved
Copy link

linux-foundation-easycla bot commented Feb 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: whitneygriffith / name: Whitney Griffith (8844238, a340947)

@whitneygriffith whitneygriffith force-pushed the release-channels branch 3 times, most recently from 63b3c88 to 90b52cf Compare February 19, 2024 18:11
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2024
@whitneygriffith whitneygriffith changed the title Implement Release channels [Tools] Implement Release channels Feb 21, 2024
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 28, 2024
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 14, 2024
@whitneygriffith
Copy link
Author

After taking into consideration our discussions around Legacy Channel. We have decided to only have two release channels, and rename them to avoid users thinking that the overall Istio Functionality has regressed.

With that being said, the Release Channels proposal has been updated to have the Standard Channel (Full Istio Functionality) and Stable Channel (GA Istio Functionality.

Standard Channel:

  • Functionality Focus: The Standard Channel encompasses the entirety of Istio’s features, regardless of their current stage of development or stability.
  • Inclusive of Experimental Features: Users opting for the Standard Channel gain access to all features offered by Istio, including those in the experimental stage. This allows for early adoption and testing of cutting-edge functionalities.
  • Varied Stability Levels: Features in the Standard Channel may range from experimental to stable, providing a broad spectrum of capabilities to users who are willing to explore and experiment with the latest advancements.

Stable Channel:

  • Stability Assurance: The Stable Channel is curated to include only the parts of Istio that have reached a stable, generally available (GA) state. This ensures reliability and consistency for production environments.
  • GA Features Only: Users selecting the Stable Channel can expect to access features that have undergone thorough testing and validation, and are deemed suitable for use in mission-critical applications.
  • Risk Mitigation: Opting for the Stable Channel minimizes the risk of encountering unexpected behavior or breaking changes, providing a dependable foundation for deploying Istio in production environments.

Please review the doc again and raise any comments.

@whitneygriffith whitneygriffith marked this pull request as ready for review March 18, 2024 18:38
@whitneygriffith whitneygriffith requested a review from a team as a code owner March 18, 2024 18:38
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 18, 2024
@whitneygriffith whitneygriffith self-assigned this Mar 20, 2024
cmd/protoc-gen-crd/openapiGenerator.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/openapiGenerator.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/openapiGenerator.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/main.go Show resolved Hide resolved
cmd/protoc-gen-crd/main.go Outdated Show resolved Hide resolved
cmd/protoc-gen-crd/openapiGenerator.go Outdated Show resolved Hide resolved
…et release channel

Signed-off-by: Whitney Griffith <whgriffi@microsoft.com>
@keithmattix
Copy link
Contributor

@istio/wg-test-and-release-maintainers istio/api#3133 is incomplete until this change + the accompanying api and pilot PRs get merged. We also want to make sure Whitney has time ti prepare blog posts and docs for release channels before 1.22 is released so please take a look!

Signed-off-by: whitneygriffith <whitney.griffith16@gmail.com>
@whitneygriffith
Copy link
Author

Do we want to keep the functionality of parsing the release channel annotations for CRD generation?

@keithmattix
Copy link
Contributor

Maybe keep this around as a long-lived branch? I can see the functionality being picked up later and it would be better not to start from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants