-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatch with strongly-typed promise return types #1
Conversation
Thanks for your great ideas, @mrcrowl . I'm going to put most of your suggestions into test. |
Thanks @istrib. Can I assume you've also seen the ideas presented at the
end of this issue?
vuejs/vue#478
…On Tue, 20 Jun 2017 at 6:51 AM, Lukasz K. ***@***.***> wrote:
Merged #1 <#1>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABtooBBqUME1nH_RhnxuHWpBXi-7zAcHks5sFsM_gaJpZM4NvW1R>
.
|
Sorry that was the wrong issue. This one:
vuejs/vuex#564
…On Tue, 20 Jun 2017 at 7:00 AM, Ben Crowl ***@***.***> wrote:
Thanks @istrib. Can I assume you've also seen the ideas presented at the
end of this issue?
vuejs/vue#478
On Tue, 20 Jun 2017 at 6:51 AM, Lukasz K. ***@***.***>
wrote:
> Merged #1 <#1>.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#1 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABtooBBqUME1nH_RhnxuHWpBXi-7zAcHks5sFsM_gaJpZM4NvW1R>
> .
>
|
Yes, I'm delving into these ideas. Thanks! |
Thanks for all the work here making it easier to work on vuex in typescript! :) May I suggest instead of having the modifiers such as IMO, it makes such terms easier to discover when using auto-complete, which is working nicely for e.g. |
@seantanly Thanks for your suggestion. I followed it up in 0972c15 and npm package 0.1.0 |
Hi @istrib,
This PR adds versions of the dispatch/dispatchNoPayload functions with overload to return strongly-typed promise (when the wrapped action returns a promise).
Love your work.
-Ben