Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ReadAll on submit #646

Merged
merged 2 commits into from
Sep 9, 2021
Merged

use ReadAll on submit #646

merged 2 commits into from
Sep 9, 2021

Conversation

FujishigeTemma
Copy link
Collaborator

No description provided.

motoki317
motoki317 reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@motoki317 motoki317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go1.16からこうした方が良いとかなかったっけ

webapp/golang/main.go Outdated Show resolved Hide resolved
webapp/golang/main.go Outdated Show resolved Hide resolved
@FujishigeTemma @motoki317
Apply suggestions from code review
012de28 
Co-authored-by: motoki317 <motoki317@gmail.com>
motoki317
motoki317 approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@motoki317 motoki317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです 👍

@FujishigeTemma FujishigeTemma merged commit 02da590 into main Sep 9, 2021
@FujishigeTemma FujishigeTemma deleted the fix/degrade-submit-assignment branch September 9, 2021 11:10
eagletmt added a commit that referenced this pull request Sep 9, 2021
@eagletmt
rust: Follow #646
e921580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motoki317 motoki317 motoki317 approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FujishigeTemma @motoki317