Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

トランザクション/ロックの修正 #682

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Conversation

motoki317
Copy link
Member

  • Read-onlyでもtransactionを使う
    • 一貫性を保つため
  • AddCourse: 実行するstmtが一つのところでtransactionを使わない
  • DownloadSubmittedAssignments: 余計なFOR SHAREを削除
  • 他軽微な修正

closes #672

@motoki317
Copy link
Member Author

motoki317 commented Sep 12, 2021

sqlx.BeginTxxにRead-onlyにできるoptionがあるみたいだけど、別言語で同様のが無いかもしれない & あまりパフォーマンスに差は無さそうと考えてとりあえず入れてないです

https://dev.mysql.com/doc/refman/5.6/en/innodb-performance-ro-txn.html

@motoki317
Copy link
Member Author

motoki317 commented Sep 12, 2021

@FujishigeTemma FujishigeTemma merged commit f18f353 into main Sep 12, 2021
@FujishigeTemma FujishigeTemma deleted the fix/webapp-tx branch September 12, 2021 07:38
eagletmt added a commit that referenced this pull request Sep 13, 2021
okashoi added a commit that referenced this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ロックが気になったところ
2 participants