Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create achievements #281

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Create achievements #281

merged 8 commits into from
Oct 4, 2023

Conversation

ospodaryk
Copy link
Contributor

@ospodaryk ospodaryk commented Sep 26, 2023 •
edited
Loading

GreenCityUser PR

[User] Create achievements #6406

Summary Of Changes 🔥

Added new fields in achievements

Changed

Methods of achievement service

Deleted

Unused methods and fields

PR Checklist Forms

(to be filled out by PR submitter)

  • Code is up-to-date with the dev branch.
  • You've successfully built and run the tests locally.
  • There are new or updated unit tests validating the change.
  • JIRA/ Github Issue number & title in PR title (ISSUE-XXXX: Ticket title)
  • This template filled (above this section).
  • Sonar's report does not contain bugs, vulnerabilities, security issues, code smells ar duplication
  • NEED_REVIEW and READY_FOR_REVIEW labels are added.
  • All files reviewed before sending to reviewers

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ospodaryk ospodaryk merged commit 62683a0 into dev Oct 4, 2023
3 checks passed
@ospodaryk ospodaryk deleted the create-achievements branch October 4, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelenSotnik HelenSotnik HelenSotnik approved these changes

@ABbondar ABbondar ABbondar approved these changes

@Maksym-Lenets Maksym-Lenets Maksym-Lenets approved these changes

@RomaMocherniuk RomaMocherniuk RomaMocherniuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ospodaryk @RomaMocherniuk @Maksym-Lenets @ABbondar @HelenSotnik