Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor emails #408

Merged
merged 24 commits into from
Oct 8, 2024
Merged

Refactor emails #408

merged 24 commits into from
Oct 8, 2024

Conversation

IliaWithHat
Copy link
Collaborator

Summary of change

  • Rewrited all emails templates to match with GreenCity project: used right logo, fonts, colors.
  • Added localization.
  • Removed unused/unnecessary code/DTO.

@IliaWithHat IliaWithHat mentioned this pull request Oct 3, 2024
Merged
@KizerovDmitriy
Copy link
Contributor

please resolve 5 issues

@IliaWithHat
Copy link
Collaborator Author

please resolve 5 issues

Every issue needed.

@KizerovDmitriy
Copy link
Contributor

resolve issues where need to define a constant, TODO stay without changes.

@IliaWithHat
Copy link
Collaborator Author

resolve issues where need to define a constant, TODO stay without changes.

Done.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IliaWithHat IliaWithHat merged commit 79a6e92 into dev Oct 8, 2024
3 checks passed
@IliaWithHat IliaWithHat deleted the refactor-emails branch October 8, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holotsvan holotsvan holotsvan approved these changes

@KizerovDmitriy KizerovDmitriy KizerovDmitriy approved these changes

@lukovskyj lukovskyj lukovskyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IliaWithHat @KizerovDmitriy @lukovskyj @holotsvan