Sync USERNAME_REGEXP with the UI one #428
Merged
+265
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these test cases were necessary. However, since the requirement to capitalize the first letter has been removed, the corresponding test cases have been eliminated.
KizerovDmitriy
approved these changes
Dec 14, 2024
holotsvan
approved these changes
Dec 14, 2024
urio999
approved these changes
Dec 14, 2024
Cr1stal423
approved these changes
Dec 14, 2024
Added more comprehensive valid and invalid test cases for various DTOs to improve coverage and validation robustness. This includes additional name formats, edge cases, and boundary scenarios for better reliability.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An inconsistency existed between the UI's regular expression and the backend’s one. This inconsistency has been rectified.
The UI's regex:
NamePattern: /^[ґҐіІєЄїЇА-Яа-яa-zA-Z](?!.*\.$)(?!.*?\.\.)(?!.*?--)(?!.*?'')[-'ʼ’ ґҐіІєЄїЇА-Яа-я\w.]{0,29}$/