Skip to content

remove unnecessary logic that was used only in one place (#1608) #4411

remove unnecessary logic that was used only in one place (#1608)

remove unnecessary logic that was used only in one place (#1608) #4411

Triggered via push December 9, 2024 18:07
Status Success
Total duration 5m 44s
Artifacts

dotnetcore.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

42 warnings
test (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test (ubuntu-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L48
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.ElasticsearchData/IElasticsearchProvider.cs#L99
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
test (ubuntu-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/Base/Api/IEntityAddOnlyRepository.cs#L100
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
test (ubuntu-latest): OutOfSchool/OutOfSchool.DataAccess/Models/Individual.cs#L32
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.DataAccess/Models/Individual.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/EmployeeRepository.cs#L22
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/Api/IEmployeeRepository.cs#L20
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (ubuntu-latest): OutOfSchool/OutOfSchool.DataAccess/Models/User.cs#L43
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L48
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.ElasticsearchData/IElasticsearchProvider.cs#L99
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
test (macOS-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/Base/Api/IEntityAddOnlyRepository.cs#L100
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
test (macOS-latest): OutOfSchool/OutOfSchool.DataAccess/Models/Individual.cs#L32
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.DataAccess/Models/Individual.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/Api/IEmployeeRepository.cs#L20
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/EmployeeRepository.cs#L22
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (macOS-latest): OutOfSchool/OutOfSchool.DataAccess/Models/User.cs#L43
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
SonarCloud
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
SonarCloud: OutOfSchool/OutOfSchool.EmailSender/Quartz/EmailSenderJobListener.cs#L53
Remove this redundant jump. (https://rules.sonarsource.com/csharp/RSPEC-3626)
SonarCloud: OutOfSchool/OutOfSchool.EmailSender/Services/EmailSenderService.cs#L51
Make 'EncodeToBase64' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
SonarCloud: OutOfSchool/OutOfSchool.EmailSender/Quartz/EmailSenderJob.cs#L88
Logging in a catch clause should pass the caught exception as a parameter. (https://rules.sonarsource.com/csharp/RSPEC-6667)
SonarCloud: OutOfSchool/OutOfSchool.EmailSender/Quartz/EmailSenderJob.cs#L93
Logging in a catch clause should pass the caught exception as a parameter. (https://rules.sonarsource.com/csharp/RSPEC-6667)
SonarCloud: OutOfSchool/OutOfSchool.EmailSender/Quartz/EmailSenderJob.cs#L101
Make 'DecodeFrom64' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
SonarCloud: OutOfSchool/OutOfSchool.EmailSender/Senders/SendGridEmailSender.cs#L46
'System.Exception' should not be thrown by user code. (https://rules.sonarsource.com/csharp/RSPEC-112)
SonarCloud: OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
SonarCloud: OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
SonarCloud: OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L48
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
SonarCloud: OutOfSchool/OutOfSchool.Common/Communication/CommunicationService.cs#L60
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
test (windows-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L18
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.Common/JsonSerializerHelper.cs#L48
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/Base/Api/IEntityAddOnlyRepository.cs#L100
XML comment has badly formed XML -- 'Expected an end tag for element 'returns'.'
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/Api/IEmployeeRepository.cs#L20
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Repository/EmployeeRepository.cs#L22
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Models/Individual.cs#L32
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Models/Individual.cs#L34
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Models/User.cs#L43
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
test (windows-latest): OutOfSchool/OutOfSchool.DataAccess/Common/Exceptions/FileStorageException.cs#L33
'Exception.Exception(SerializationInfo, StreamingContext)' is obsolete: 'This API supports obsolete formatter-based serialization. It should not be called or extended by application code.' (https://aka.ms/dotnet-warnings/SYSLIB0051)