Added more test

OutOfSchool/OutOfSchool.BusinessLogic/Services/PositionService.cs

@@ -85,7 +85,7 @@ public async Task DeleteAsync(Guid id, Guid providerOwnerId)
     {
         var position = await _entityRepositoryBase.GetById(id);
 
-        if (position == null || position.IsDeleted)
+        if (position == null || position.IsDeleted == true)
         {
             _logger.LogError($"Position with ID {id} not found.");
             throw new KeyNotFoundException($"Position with ID {id} not found or it was deleted.");

OutOfSchool/OutOfSchool.WebApi.Tests/Controllers/PositionControllerTests.cs

@@ -139,6 +139,45 @@ public async Task UpdatePosition_WithValidInput_ShouldReturnUpdatedPosition()
         Assert.AreEqual(positionDto.FullName, updatedPosition.FullName);
     }
 
+    [Test]
+    public async Task DeletePosition_WhichDeleted_ShouldReturnNotFound()
+    {
+        // Arrange
+        currentUserService.Setup(s => s.UserId).Returns(providerId.ToString());
+        currentUserService.Setup(s => s.IsInRole(Role.Provider)).Returns(true);
+
+        var deletedPosition = positionDto;
+        deletedPosition.IsDeleted = true;
+
+        positionService
+            .Setup(s => s.DeleteAsync(deletedPosition.Id, providerId))
+            .ThrowsAsync(new KeyNotFoundException($"Position with ID {deletedPosition.Id} not found or it was deleted."));
+
+        // Act
+        var result = await controller.Delete(deletedPosition.Id);
+
+        // Assert
+        Assert.IsInstanceOf<NotFoundObjectResult>(result);
+        var objectResult = result as NotFoundObjectResult;
+        Assert.IsNotNull(objectResult); // Ensure the cast succeeded
+        Assert.AreEqual($"Position with ID {deletedPosition.Id} not found or it was deleted.", objectResult.Value);
+    }
+
+    [Test]
+    public async Task DeletePosition_WithValidInput_ShoudReturnNoContent()
+    {
+        // Arrange
+        currentUserService.Setup(s => s.UserId).Returns(providerId.ToString());
+        currentUserService.Setup(s => s.IsInRole(Role.Provider)).Returns(true);
+
+        // Act 
+        var result = await controller.Delete(positionDto.Id);
+
+        // Act
+        Assert.IsInstanceOf<NoContentResult>(result); // Verify the result type
+    }
+
+
     private PositionUpdateDto FakePositionUpdateDto(Guid providerId, PositionDto oldPosition)
     {        
         return new PositionUpdateDto

OutOfSchool/OutOfSchool.WebApi/Controllers/V1/PositionController.cs

@@ -5,7 +5,7 @@
 
 namespace OutOfSchool.WebApi.Controllers.V1;
 [Route("api/v{version:apiVersion}/[controller]")]
-[Authorize]
+[Authorize(Roles = "provider")]
 [ApiController]
 public class PositionController : ControllerBase
 {
@@ -121,6 +121,14 @@ public async Task<IActionResult> Delete(Guid id)
             await positionService.DeleteAsync(id, providerOwnerId);
             return NoContent();
         }
+        catch (KeyNotFoundException ex)
+        {
+            return NotFound(ex.Message); 
+        }
+        catch (UnauthorizedAccessException ex)
+        {
+            return Forbid(ex.Message);
+        }
         catch (Exception ex)
         {
             return BadRequest(ex.Message);