Removing validation input hint #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
approved these changes
Jun 2, 2022
litvinets
added a commit
that referenced
this pull request
Jun 2, 2022
* removing old form control * Update create-direction.component.spec.ts * fix * fix module * Update shared.module.ts * Update create-application.component.spec.ts
LeraKornienko
added a commit
that referenced
this pull request
Jun 2, 2022
* add pagination dropdown for items per page selection dropdown * Pagination dropdown Pagination dropdown * paginator state paginator state * Comments Comments * conflict fix * conflict fix1 * [Create Application] - do not display create-application button for mobile view for the wrong role #1223 (#1242) * Update create-direction.component.ts (#1247) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 (#1249) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 * increased area clicking * refactoring admin-state * fix mobile view (#1241) * Removing validation input hint (#1237) * removing old form control * Update create-direction.component.spec.ts * fix * fix module * Update shared.module.ts * Update create-application.component.spec.ts * [Applying for a workshop] Incorrect behavior is displayed when editing the child's information (#1231) * cancel navigation * fix editMode submit button * onSubmit navigation * fix editMode submit button * style guide Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> * add validation-hint fore create-direction, create-department, create class form controls (#1236 ) * merge * Update paginator.component.ts * fix * import removing * Update result.component.ts Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com> Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> Co-authored-by: Pabloostr <47858505+Pabloostr@users.noreply.github.com> Co-authored-by: Aleksandr Perepichai <o.perepichai@gmail.com>
LeraKornienko
pushed a commit
that referenced
this pull request
Jun 7, 2022
* removing old form control * Update create-direction.component.spec.ts * fix * fix module * Update shared.module.ts * Update create-application.component.spec.ts
LeraKornienko
added a commit
that referenced
this pull request
Jun 7, 2022
* add pagination dropdown for items per page selection dropdown * Pagination dropdown Pagination dropdown * paginator state paginator state * Comments Comments * conflict fix * conflict fix1 * [Create Application] - do not display create-application button for mobile view for the wrong role #1223 (#1242) * Update create-direction.component.ts (#1247) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 (#1249) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 * increased area clicking * refactoring admin-state * fix mobile view (#1241) * Removing validation input hint (#1237) * removing old form control * Update create-direction.component.spec.ts * fix * fix module * Update shared.module.ts * Update create-application.component.spec.ts * [Applying for a workshop] Incorrect behavior is displayed when editing the child's information (#1231) * cancel navigation * fix editMode submit button * onSubmit navigation * fix editMode submit button * style guide Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> * add validation-hint fore create-direction, create-department, create class form controls (#1236 ) * merge * Update paginator.component.ts * fix * import removing * Update result.component.ts Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com> Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> Co-authored-by: Pabloostr <47858505+Pabloostr@users.noreply.github.com> Co-authored-by: Aleksandr Perepichai <o.perepichai@gmail.com>
LeraKornienko
added a commit
that referenced
this pull request
Jun 7, 2022
* [Create Application] - do not display create-application button for mobile view for the wrong role #1223 (#1242) * Update create-direction.component.ts (#1247) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 (#1249) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 * increased area clicking * refactoring admin-state * fix mobile view (#1241) * Removing validation input hint (#1237) * removing old form control * Update create-direction.component.spec.ts * fix * fix module * Update shared.module.ts * Update create-application.component.spec.ts * [Applying for a workshop] Incorrect behavior is displayed when editing the child's information (#1231) * cancel navigation * fix editMode submit button * onSubmit navigation * fix editMode submit button * style guide Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> * add validation-hint fore create-direction, create-department, create class form controls (#1236 ) * #1115 pagination drop-down (#1257) * add pagination dropdown for items per page selection dropdown * Pagination dropdown Pagination dropdown * paginator state paginator state * Comments Comments * conflict fix * conflict fix1 * [Create Application] - do not display create-application button for mobile view for the wrong role #1223 (#1242) * Update create-direction.component.ts (#1247) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 (#1249) * [Create Direction] - remove routing when you click on delete/edit icon on category-card #1248 * increased area clicking * refactoring admin-state * fix mobile view (#1241) * Removing validation input hint (#1237) * removing old form control * Update create-direction.component.spec.ts * fix * fix module * Update shared.module.ts * Update create-application.component.spec.ts * [Applying for a workshop] Incorrect behavior is displayed when editing the child's information (#1231) * cancel navigation * fix editMode submit button * onSubmit navigation * fix editMode submit button * style guide Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> * add validation-hint fore create-direction, create-department, create class form controls (#1236 ) * merge * Update paginator.component.ts * fix * import removing * Update result.component.ts Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com> Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> Co-authored-by: Pabloostr <47858505+Pabloostr@users.noreply.github.com> Co-authored-by: Aleksandr Perepichai <o.perepichai@gmail.com> * social groups (#1261) * Fixed button letter. Lowercase changed to uppercase. (#1140) (#1262) * [Personal cabinet Parent] The title is "Кабінет Надавача" instead of "Кабінет Користувача" (#1239) * fix cabinet title for parent * fix * add takeUntill * chng to async * fix Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> * small window (#1264) * fixes (#1270) * current tab (#1267) * Application improve functionality * done done Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com> Co-authored-by: Pabloostr <47858505+Pabloostr@users.noreply.github.com> Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com> Co-authored-by: Aleksandr Perepichai <o.perepichai@gmail.com> Co-authored-by: Ілля Овсянніков <50924109+Illya97@users.noreply.github.com> Co-authored-by: Olya <ola.shy@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old validation-component from shared-module and the rest of the components.
Now we following the new component for validations https://github.com/ita-social-projects/OoS-Frontend/wiki/Validation-Hint-Tutorial