[Create Workshop] - Image Cropper #1279 #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Candidate 1.0.0
remove path (#1245)
litvinets
requested changes
Jun 20, 2022
There was a problem hiding this comment.
- teachers' images are not uploading
- image size/correlation for the workshop cover image is not correct (either fix the correlation of the cropper or fix the width/height of the card and card-image).
- I found a bug, when you first open the cropper, then click "cancel" and then you are trying to upload the image/open the cropper again - it doesn't work. Nothing is happening
|
cover image resolution 300/180 |
litvinets
requested changes
Jun 24, 2022
src/app/shared/components/image-cropper-modal/image-cropper-modal.component.html
Outdated
Show resolved
Hide resolved
src/app/shared/components/image-cropper-modal/image-cropper-modal.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/image-cropper-modal/image-cropper-modal.component.ts
Outdated
Show resolved
Hide resolved
litvinets
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #1279