Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create Workshop] - Image Cropper #1279 #1329

Merged
merged 32 commits into from
Jun 27, 2022
Merged

[Create Workshop] - Image Cropper #1279 #1329

merged 32 commits into from
Jun 27, 2022

Conversation

perepichai
Copy link
Contributor

Task #1279

Copy link
Contributor

@litvinets litvinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. teachers' images are not uploading
  2. image size/correlation for the workshop cover image is not correct (either fix the correlation of the cropper or fix the width/height of the card and card-image).
  3. I found a bug, when you first open the cropper, then click "cancel" and then you are trying to upload the image/open the cropper again - it doesn't work. Nothing is happening

@litvinets
Copy link
Contributor

cover image resolution 300/180
images 7/4
fix image upload repeating

Copy link
Contributor

@litvinets litvinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix please creating of teacher image, currently, it doesn't work

@perepichai perepichai merged commit 2ae0e3d into develop Jun 27, 2022
@perepichai perepichai deleted the image-cropper branch June 27, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants