-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[personal-cabinet/provider-admins]Show button for deputy/admin creation correctly #1355 #1356
Merged
Merged
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
acb54cd
Merge pull request #879 from ita-social-projects/develop
DmyMi a2f72a9
Merge pull request #1244 from ita-social-projects/develop
DmyMi 61b6afd
Merge pull request #1246 from ita-social-projects/develop
DmyMi 60b0ad3
fix the view of btn
Olya-web7 9ba6253
fix the routes for all
Olya-web7 a7a1355
fix the administruvannia in header for providerAdmin
Olya-web7 715b95e
fix
Olya-web7 3c0fec0
add btn on init
Olya-web7 0f7101e
Merge branch 'develop' into bnt-to-add-admin/deputy
Olya-web7 f4d0af6
Merge branch 'develop' into bnt-to-add-admin/deputy
Olya-web7 62f54de
return back takeUntil
Olya-web7 c941f43
Merge branch 'bnt-to-add-admin/deputy' of https://github.com/ita-soci…
Olya-web7 ae998aa
Update create-provider-admin.component.ts
litvinets 3a464e7
Merge branch 'bnt-to-add-admin/deputy' of https://github.com/ita-soci…
litvinets bb1cb62
Merge remote-tracking branch 'origin' into bnt-to-add-admin/deputy
litvinets 0293962
fix
litvinets 9e70c2c
test fix
litvinets 10883b0
Update create-provider-admin.component.spec.ts
litvinets a3483a2
Update create-provider-admin.component.spec.ts
litvinets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ export class ProviderAdminsComponent implements OnInit { | |
provider: Provider; | ||
filter = new FormControl(''); | ||
filterValue: string; | ||
btnView: string= providerAdminRoleUkr.all; | ||
btnView: string = providerAdminRoleUkr.all; | ||
destroy$: Subject<boolean> = new Subject<boolean>(); | ||
tabIndex: number; | ||
subrole: string; | ||
|
@@ -88,11 +88,10 @@ export class ProviderAdminsComponent implements OnInit { | |
.subscribe((providerAdmins: ProviderAdmin[]) => { | ||
this.providerAdmins = this.updateStructureForTheTable(providerAdmins); | ||
}); | ||
|
||
this.route.queryParams | ||
.pipe(takeUntil(this.destroy$)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why did you remove it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. returned it back) |
||
.subscribe((params: Params) => { | ||
this.tabIndex = Object.keys(this.providerAdminRole).indexOf(params['role']); | ||
this.btnView = providerAdminRoleUkr[params['role']]; | ||
this.tabIndex = Object.keys(this.providerAdminRole).indexOf(params['role']); | ||
}); | ||
|
||
this.provider$ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add button on init of this component