Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workshop creation] "Додати ще один розділ" button doesn't open new area #1368 #1369

Merged
merged 16 commits into from
Jun 24, 2022
Merged

[Workshop creation] "Додати ще один розділ" button doesn't open new area #1368 #1369

merged 16 commits into from
Jun 24, 2022

Conversation

perepichai
Copy link
Contributor

Task #1368

@perepichai perepichai requested a review from litvinets June 23, 2022 16:47
litvinets
litvinets reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@litvinets litvinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create provider doesn't work. There still description control, that does not allow to submit new provider/ edit provider. remove this functionality
image

@litvinets
Copy link
Contributor

add the same functionality to create-provider. Push first form to the array on init
image

litvinets
litvinets requested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@litvinets litvinets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the scope of this PR, please remove old description filed from the provider and workshop. According to the last updates from backend, this field were removed from the models

@perepichai perepichai requested a review from litvinets June 24, 2022 09:27
@perepichai perepichai merged commit ad68add into develop Jun 24, 2022
@perepichai perepichai deleted the fix/add-section branch June 24, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litvinets litvinets litvinets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perepichai @litvinets