-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Achievements #1357 #1370
Achievements #1357 #1370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done:)
{ id: 7, name: "Переможці та учасники олімпіад міжнародного та всеукраїнського рівнів" } | ||
] | ||
|
||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit lost:)
); | ||
} | ||
|
||
createAchievement(achievement: Achievement): Observable<Object> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return typo is Observable
return this.http.post('/api/v1/Achievement/Create', achievement); | ||
} | ||
|
||
getAchievementsTitle(achievement: Achievement): Observable<Object> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is redundant? the title does not match the actual request
import { Achievement } from 'src/app/shared/models/achievement.model'; | ||
import { AchievementsComponent } from './achievements.component'; | ||
|
||
// const MockAchievement = {Achievement: typeof Achievement}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented mock
No description provided.