added guard, fixed some errors with styling, and added some features #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
requested changes
Apr 8, 2021
| export class CanDeactivateGuard implements CanDeactivate<ProviderConfigComponent> { | ||
| canDeactivate(component: ProviderConfigComponent): boolean { | ||
| if (component.orgFormGroup.dirty || component.addressFormGroup.dirty || component.photoFormGroup.dirty) { | ||
| return confirm('У вас є не збережені дані, покинути сторінку?'); |
| @@ -82,7 +82,7 @@ | |||
| </div> | |||
| <div class="web-page"> | |||
| <label for="webPageForm">Веб сайт</label> | |||
| <input type="text" id="webPageForm" formControlName="webPage"> | |||
| <input type="text" id="webPageForm" formControlName="webPage" placeholder="380XXXXXXX"> | |||
There was a problem hiding this comment.
is there any reason using ids instead of classes?
There was a problem hiding this comment.
phone number placeholder for web page field?
| >ДАЛІ | ||
| </button> | ||
| </div> | ||
| <button class="buttons1_reset" type="button" (click)="formReset()">СКАСУВАТИ</button> |
There was a problem hiding this comment.
use meaningful class names and follow conwention
| @@ -167,9 +164,9 @@ | |||
| </div> | |||
| </ng-container> | |||
| <div class="buttons2"> | |||
There was a problem hiding this comment.
we dont need 3 sets of buttons, move them outside individual step and use for whole stepper
| @@ -101,5 +102,18 @@ export class ProviderConfigComponent implements OnInit { | |||
| break; | |||
| } | |||
| } | |||
|
|
|||
| formReset(): void { | |||
dmitryy90
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.