Bug/#165 workshop naming consistent #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
requested changes
Apr 20, 2021
src/app/shell/main/main.component.ts
Outdated
| ngOnInit(): void { | ||
| this.store.dispatch([new GetCategories(), | ||
| new GetCategoriesIcons(), | ||
| new GetPopWorkshops(), | ||
| new ChangePage(true) | ||
| ]); | ||
|
|
||
| this.cards$.subscribe(cards => | ||
| this.cards = cards |
There was a problem hiding this comment.
what the reason for this change?
There was a problem hiding this comment.
I thought that the structure of all these components that contains workshop should have the same method of realizing cards.
There was a problem hiding this comment.
use cards$ directly from the store through async pipe
dmitryy90
requested changes
Apr 21, 2021
src/app/shell/main/main.component.ts
Outdated
| ngOnInit(): void { | ||
| this.store.dispatch([new GetCategories(), | ||
| new GetCategoriesIcons(), | ||
| new GetPopWorkshops(), | ||
| new ChangePage(true) | ||
| ]); | ||
|
|
||
| this.cards$.subscribe(cards => | ||
| this.cards = cards |
There was a problem hiding this comment.
use cards$ directly from the store through async pipe
dmitryy90
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.