Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oliinyk / 2267-2269 Create child dirty and validation #2270

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Oliinyk / 2267-2269 Create child dirty and validation #2270

merged 5 commits into from
Oct 10, 2023

Conversation

doliinyk
Copy link
Member

@doliinyk doliinyk commented Oct 6, 2023 •
edited
Loading

#2267
#2268
#2269

  • Refactored create forms & add dirty condition to save them
  • Fixed achievement editing & creating & translation issue in card
  • Removed space character in name regex

@doliinyk doliinyk requested review from DmyMi and humanmantis October 6, 2023 07:44
@doliinyk doliinyk self-assigned this Oct 6, 2023
@doliinyk doliinyk changed the title Oliinyk / 2267 2269 Create child dirty and validation Oliinyk / 2267-2269 Create child dirty and validation Oct 6, 2023
This was referenced Oct 10, 2023
Closed
Closed
Closed
@doliinyk doliinyk merged commit 99ff6a4 into develop Oct 10, 2023
2 checks passed
@doliinyk doliinyk deleted the Oliinyk/2267_2269_CreateChildDirtyAndValidation branch October 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humanmantis humanmantis humanmantis approved these changes

@DmyMi DmyMi Awaiting requested review from DmyMi

Assignees

@doliinyk doliinyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doliinyk @humanmantis