Shutov / Create interface to upload employee #2633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarianS23
changed the title
…l components from the original branch
|
humanmantis
requested changes
Oct 14, 2024
src/app/shared/base-components/upload-excel/upload-excel.component.scss
Outdated
Show resolved
Hide resolved
src/app/shared/base-components/upload-excel/upload-excel.component.scss
Outdated
Show resolved
Hide resolved
src/app/shared/base-components/upload-excel/upload-excel.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/base-components/upload-excel/upload-excel.component.ts
Outdated
Show resolved
Hide resolved
| [ngClass]="{ | ||
| 'error-field-empty': element.errors.employeeSurnameEmpty, | ||
| 'error-field-wrong-length': element.errors.employeeSurnameLength, | ||
| 'error-field-wrong-language':element.errors.employeeSurnameLanguage |
There was a problem hiding this comment.
fix formatting, same below
src/app/shared/base-components/upload-excel/upload-excel.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/base-components/upload-excel/upload-excel.component.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private validateField(fieldName: string, item: any, config: FieldValidationConfig): void { | ||
| if (config.checkEmpty && !item[fieldName]) { |
There was a problem hiding this comment.
I would prefer to update this method. Here are my suggestions:
- Use a validator map
{
checkLanguage : (value) => !NO_LATIN_REGEX.test(value)
...
}
- Create constants for magic numbers (2 and 50)
- As I understand it, in the table we show only one error for one field - there are 2 ways -> show all errors or exit the method when at least one error is detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.