Litviniuk/replace flex layout with tailwind #2657
Conversation
package.json
Outdated
| @@ -71,6 +71,7 @@ | |||
| "@types/node": "^18.11.9", | |||
| "@typescript-eslint/eslint-plugin": "7.5.0", | |||
| "@typescript-eslint/parser": "7.5.0", | |||
| "autoprefixer": "^10.4.20", | |||
There was a problem hiding this comment.
Are autoprefix and postcss required? I don't see that you include them in the plugins, maybe we can remove them?
There was a problem hiding this comment.
Remove @angular/flex-layout when done
There was a problem hiding this comment.
I don't see the removed package in yarn.lock file. Did you use yarn remove <package>?
| @@ -12,6 +12,11 @@ | |||
| } | |||
| .wrapper { | |||
| margin-top: 16px; | |||
| display: flex; | |||
There was a problem hiding this comment.
Why didn't you use tailwind classes in this case?
| max-width: max-content; | ||
| line-height: 17px; | ||
| color: black; | ||
| place-content: flex-start space-between; |
There was a problem hiding this comment.
Why didn't you use tailwind classes in this case?
There was a problem hiding this comment.
because there are the same properties for both elements and there is no reason to dublicate it
There was a problem hiding this comment.
Yes, but you can just use the ready-made tailwind classes, so it shouldn't be a problem.
There was a problem hiding this comment.
i made that change in previous commit as you said
|
|
||
| @media (max-width: 1280px) { | ||
| .view-control-panel { | ||
| display: flex; |
There was a problem hiding this comment.
Why didn't you use tailwind classes in this case?
…github.com/ita-social-projects/OoS-Frontend into litviniuk/replace-flexLayout-with-tailwind
|
|
comment for future duplicate - we had to revert this pr :) |
all flexLayout usages were replaced with Tailwind CSS