Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39 feature/ user token and registration #52

Merged
merged 16 commits into from
Feb 12, 2021
Merged

Conversation

litvinets
Copy link
Contributor

@litvinets litvinets commented Feb 12, 2021

  1. Added registration and login
  2. Added authorization, logout, and call API
  3. Added user state
  4. Added changing of header view depending on the user state
  5. HeaderComponent, AppComponent have fixed tests
  6. FirterCityComponent has commented tests because of the loop (seems like)

@litvinets litvinets requested a review from dmitryy90 February 12, 2021 12:04
Увійти
</div>
<ng-container
*ngIf="(isAuthorized$ | async) then YesAuthorized; else NotAuthorized">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it more meaningful to use authorized and unauthorized instead of yes no prefixes?

@litvinets litvinets merged commit 521c964 into develop Feb 12, 2021
@litvinets litvinets deleted the #39-feature/-user-token branch February 12, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants