#743 #752
Merged
#743 #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryy90
requested changes
Jan 13, 2022
| @@ -1,7 +1,13 @@ | |||
| <div class="container" fxLayout="column" | |||
| [fxLayout.lt-lg]="(isMobileScreen$ | async) ? 'column' : 'row wrap'" | |||
| [fxLayoutAlign]="(isMobileScreen$ | async) ? 'none' : 'center start'"> | |||
| <app-actions *ngIf="role !== Role.provider" [role]="role" [workshop]="workshop"></app-actions> | |||
|
|
|||
There was a problem hiding this comment.
try to follow general styleguides of the application and fix indentations
litvinets
requested changes
Jan 14, 2022
| @@ -28,6 +29,7 @@ export class ActionsComponent implements OnInit, OnDestroy { | |||
| @Input() workshop: Workshop; | |||
| @Input() role: string; | |||
|
|
|||
|
|
|||
|
wrong implementation. The card should be placed before the workshop-details and workshop images, right under the header |
dmitryy90
approved these changes
Jan 17, 2022
litvinets
requested changes
Jan 18, 2022
| @@ -11,8 +11,9 @@ import { Favorite } from 'src/app/shared/models/favorite.model'; | |||
| import { CreateFavoriteWorkshop, DeleteFavoriteWorkshop } from 'src/app/shared/store/user.actions'; | |||
| import { ShowMessageBar } from 'src/app/shared/store/app.actions'; | |||
| import { ActivatedRoute } from '@angular/router'; | |||
| import { takeUntil } from 'rxjs/operators'; | |||
| import { filter, map, takeUntil } from 'rxjs/operators'; | |||
There was a problem hiding this comment.
remove please unused operators
| ngOnInit(): void { | ||
| this.isMobileScreen$.pipe( | ||
| takeUntil(this.destroy$) | ||
| ).subscribe((boolean) => this.isMobileScreen = boolean) |
There was a problem hiding this comment.
add type please
Suggested change
| ).subscribe((boolean) => this.isMobileScreen = boolean) | |
| ).subscribe((isMobile: boolean) => this.isMobileScreen = isMobile) |
| @@ -13,12 +14,24 @@ import { Observable } from 'rxjs'; | |||
| export class SideMenuComponent implements OnInit { | |||
There was a problem hiding this comment.
you added ngOnDesctroy, then you need to add this interface here
Suggested change
| export class SideMenuComponent implements OnInit { | |
| export class SideMenuComponent implements OnInit, OnDestroy { |
| [fxLayoutAlign]="isMobileScreen ? 'none' : 'center start'"> | ||
| <ng-conteiner *ngIf="!isMobileScreen"> | ||
| <app-actions *ngIf="(role !== Role.provider)" [role]="role" [workshop]="workshop" | ||
| [isMobileScreen$]="isMobileScreen$"> |
There was a problem hiding this comment.
if you're passing this value to the child component, why I don't see the Input for it? I see you're using selector in actions.ts, then maybe this input should be removed? Otherwise, remove selector.
litvinets
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done